Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No warning that the title of a game should contain only english text and (or) numbers #2414

Closed
Marc-Spector opened this issue Nov 2, 2021 · 2 comments · Fixed by #2417
Closed
Labels
Milestone

Comments

@Marc-Spector
Copy link
Collaborator

Marc-Spector commented Nov 2, 2021

Trying to create a game with the title with non-english text (for example +800 ты не пройдешь!) and click "Create".
Nothing will happen after that.

The following was printed in the log file:

2021-11-02 18:29:02.793 INFO 3940 --- [pool-3-thread-10] c.f.c.patch.GameBinariesUpdateTaskImpl : Updating binaries to 3724
2021-11-02 18:29:02.870 INFO 3940 --- [reactor-tcp-nio-2] com.faforever.commons.lobby.FafLobbyApi : Outbound channel cancelled
2021-11-02 18:29:02.871 INFO 3940 --- [reactor-tcp-nio-2] com.faforever.commons.lobby.FafLobbyApi : Inbound channel cancelled
2021-11-02 18:29:02.872 INFO 3940 --- [reactor-tcp-nio-2] com.faforever.commons.lobby.FafLobbyApi : Disconnected from server

Client Version:
2021.10.0

@Sheikah45
Copy link
Member

Ah yeah that is probably the combination of the utf-8 encoding and server freaking out that the message doesn't follow protocol

@Askaholic
Copy link
Collaborator

Yea the server expects that the client should be validating game titles before sending them: https://github.com/FAForever/server/blob/88778a33e5354bd9640261f083cffd731e3f0be0/server/lobbyconnection.py#L968

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants