Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong players written to fafreplay header for local replays #2495

Closed
Askaholic opened this issue Dec 29, 2021 · 0 comments · Fixed by #2569
Closed

Wrong players written to fafreplay header for local replays #2495

Askaholic opened this issue Dec 29, 2021 · 0 comments · Fixed by #2569
Labels

Comments

@Askaholic
Copy link
Collaborator

In FAForever/server#831 we stopped freezing the list of players when the game launches. The client basically just dumps the game_info message contents to the fafreplay header at the end of the game which now only includes the players who stayed connected until the end of the game.

The client will probably have to do its own freezing of the player list when the game starts and use it when creating the fafreplay header at the end of the game. Either that or it should display the player list by parsing the scfareplay header instead as that will still contain the correct player list. In that case there is probably no point to dumping the player list into the fafreplay header at all.

Wanna have the bug fixed quickly?
Visit Issue hunt...
Issue hunt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant