Chat tab is broken after running the client

[Marc-Spector]

For start see the log.
It is unstable bug. After running the client, sometimes may call onUserJoinedChannel event before initialization default chat channel will be initialized.

I can't reproduce the bug manually.

2022-04-03 15:37:08.587 ERROR 8224 --- [JavaFX Application Thread] c.f.c.exception.GlobalExceptionHandler   : Uncaught exception on Thread[JavaFX Application Thread,5,main]: 

java.lang.IndexOutOfBoundsException: Index: -1, Size: 0
	at java.base/java.util.ArrayList.rangeCheckForAdd(ArrayList.java:756)
	at java.base/java.util.ArrayList.add(ArrayList.java:481)
	at com.sun.javafx.collections.ObservableListWrapper.doAdd(ObservableListWrapper.java:101)
	at javafx.collections.ModifiableObservableListBase.add(ModifiableObservableListBase.java:158)
	at com.faforever.client.chat.ChatController.addTab(ChatController.java:129)
	at com.faforever.client.chat.ChatController.getOrCreateChannelTab(ChatController.java:116)
	at com.faforever.client.chat.ChatController.lambda$onUserJoinedChannel$13(ChatController.java:261)
	at com.sun.javafx.application.PlatformImpl.lambda$runLater$10(PlatformImpl.java:457)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:399)
	at com.sun.javafx.application.PlatformImpl.lambda$runLater$11(PlatformImpl.java:456)
	at com.sun.glass.ui.InvokeLaterDispatcher$Future.run(InvokeLaterDispatcher.java:96)
	at com.sun.glass.ui.win.WinApplication._runLoop(Native Method)
	at com.sun.glass.ui.win.WinApplication.lambda$runLoop$3(WinApplication.java:184)
	at java.base/java.lang.Thread.run(Thread.java:833)

Windows

2022.3.0

[Eternal-ll]

Maybe related, but i found a bug in IRC notification system, when you join to the channel it wont notify you that "you" joined to the channel. But if you join the same channel secondly, after leaving from it, there will be notification that "you" joined to the channel and "you" will come with user list too. I noticed it when i had double "me" instance in chats xD

[Sheikah45]

Fixed in recent chat rework