Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indeterminate progress indicator for downloads #2664

Closed
BlackYps opened this issue Apr 15, 2022 · 2 comments
Closed

Indeterminate progress indicator for downloads #2664

BlackYps opened this issue Apr 15, 2022 · 2 comments
Labels

Comments

@BlackYps
Copy link
Collaborator

Describe the bug
When downloading maps, mods or a new game version the progress indicator in the status bar at the bottom of the client is indeterminate. This is inconvenient because you get no feedback how much the download progressed and if it is making progress at all. Interestingly it works as desired when downloading the next client version from inside the client.

To Reproduce
Download a sufficiently large file so you can get a good look at the progress indicator

@BlackYps BlackYps added the bug label Apr 15, 2022
@Sheikah45
Copy link
Member

The cloudflare CDN does not provide the Content-Length header to tell us how big the file is without downloading it, so have to figure out some other way to get the size of the files

@Sheikah45
Copy link
Member

This works for the largest files of the patches as they are not behind the CDN. For the others that are smaller I think the indeterminate is best for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants