coop replay failures in latest update

[jnorthrup]

Describe the bug

loading prothyon coop map replay from leaderboard.

To Reproduce
linux platform, steam installation, launf faf, launch coop replay from net.

OS
Linux

[Marc-Spector]

If the game starts and cannot play the replay, then it is something related to the replay, but not to the client.

[jnorthrup]

this is what the missing replay file looks like from the dialog box.

I have noticed the the client uses a CurrentWorkingDir that cannot be changed to an absolute path when for example specifying the run.sh script anywhere other than ~/.faforever/bin (on linux)

it seems possible that this java CWD could affect replays as well, attempting to find a relative path of /home/jim/.faforever/cache/home/jim/.faforever/cache/temp.scfareplay

[jnorthrup]

the usecase is as shown here.

i have opened the source code and the string "scfareplay" is not (previous file mask hid this) in the project loaded by intellij from gradle.

the stackrtace is inconclusive as to the source of the method it only goes as far as a javafx library.

the is the replay as downloaded:

i prepended "z:" to the filename before it calls the exe like so just in case this helped Wine see the VFS better.

the error message dialog shows something like CWD being prepended to z:/

[jnorthrup]

removing the z:/ reproduces the error in the beginning of the issue.

client log reports this
2022-07-22 15:53:59.746 INFO 2091090 --- [ForkJoinPool.commonPool-worker-5] c.f.client.fa.ForgedAllianceService : Starting Forged Alliance with command: [protontricks-launch, --appid, 9420, %USER_PROFILE%/.faforever/bin/ForgedAlliance.exe, /init, init.lua, /nobugreport, /log, %USER_PROFILE%/.faforever/logs/game_16403379.log, /replay, %USER_PROFILE%/.faforever/cache/temp.scfareplay, /replayid, 16403379] in directory: %USER_PROFILE%/.faforever/bin

[jnorthrup]

when prepending a Z: to %USER_PROFILE% the coop replays fail but otherwise all else still works as to be expected under wine with Z-drive, and to boot, normal replays do still also work.

2022-07-22 16:27:02.662 INFO 2101110 --- [ForkJoinPool.commonPool-worker-10] c.f.client.fa.ForgedAllianceService : Starting Forged Alliance with command: [protontricks-launch, --appid, 9420, Z:%USER_PROFILE%/.faforever/bin/ForgedAlliance.exe, /init, init.lua, /nobugreport, /log, Z:%USER_PROFILE%/.faforever/logs/game_17565031.log, /replay, Z:%USER_PROFILE%/.faforever/cache/temp.scfareplay, /replayid, 17565031] in directory: Z:%USER_PROFILE%/.faforever/bin

so the question is why do recent coop replays fail ?

[Marc-Spector]

@jnorthrup
Sorry for my mistake. I run the replay specified in your screenshot and get the same error. The problem is that the client does not download the version of the game specified in the replay file (it is 3704).
Therefore, the replay will not start in the game with version 3740, which we are currently using.

[jnorthrup]

@Marc-Spector @Sheikah45 when i check out faf develop and run ghoullord's prothyon campaign as shown i see the dsync message then the map but the scenario is not running. I see the chat dialog pop up "ghoullord starting gun upgrade" but the map is empty

[jnorthrup]

replay from 1 year ago to the day is working

[Sheikah45]

Seems like GhoulLord's replay was run with some mod that is not known to the client so cannot be replayed without that mod else it will desync