Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The client does not notify that a lobby is full when you watching a replay #2836

Closed
Marc-Spector opened this issue Nov 1, 2022 · 3 comments · Fixed by #2847
Closed

The client does not notify that a lobby is full when you watching a replay #2836

Marc-Spector opened this issue Nov 1, 2022 · 3 comments · Fixed by #2847
Labels

Comments

@Marc-Spector
Copy link
Collaborator

Marc-Spector commented Nov 1, 2022

To Reproduce

  1. Allow watching replays while in a game via Settings -> Forget Alliance Forever
  2. Host a game or join to any game
  3. Watch any replay
  4. Wait when a lobby is full

Log or error message
No need

Expected behavior
Notify an user that the lobby is full

Screenshots
No need

OS
Windows

Client Version
2022.10.0-alpha-2

@Sheikah45
Copy link
Member

The issue is that the game full notification only plays when FA is not focused. I don't know if we can tell which window belongs to which game.

Only solution would be to send the game full no matter if the window is focused or not.

@Marc-Spector
Copy link
Collaborator Author

It is easier to find out how many game instances were run using the method getAllWindows(bool) of class com.sun.jna.platform.WindowUtils.
We get all the windows and filter by Forged Alliance title.

image

@Sheikah45
Copy link
Member

Yes but is there a way to figure out which one is the game and which one is the replay? Also to figure out if the one that is the lobby already has focus?

I think it might be worse to flash both windows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants