Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows/Firefox fail to log in #3109

Closed
disconsented opened this issue Jan 5, 2024 · 5 comments
Closed

Windows/Firefox fail to log in #3109

disconsented opened this issue Jan 5, 2024 · 5 comments
Labels

Comments

@disconsented
Copy link

Describe the bug
Trying to log in to the client with Firefox as the default browser, OpenID connect consent is successfully given, and we get redirected to something like http://127.0.0.1:64351/?code=NXq-MmI7GkHYWyi7KAVKa3sqoc102bTWmvTRUNCATED&scope=openid+offline+public_profile+upload_map+upload_mod+lobby&state=YqWppNPOzAQsoyJ8wU0OOGrlbSTRUNCATED, where the client then reports what's below.

This doesn't happen in edge, so I assume it's a Windows/FF specific issue.

Log or error message

Client Version: 2023.12.3
java.lang.IllegalStateException: Could not extract value with pattern 'code=([^ &]+)' from: zv�%�H�@�Ҁ-g]>4�R`&V.�M�4���e y.S�;��ݯ/\��+i�?��.��xŅ�da(�"�+�/̨̩�,�0�
	at com.faforever.client.login.OAuthValuesReceiver.extractValue(OAuthValuesReceiver.java:141)
	at com.faforever.client.login.OAuthValuesReceiver.readValues(OAuthValuesReceiver.java:133)
	at com.faforever.client.login.OAuthValuesReceiver.readValues(OAuthValuesReceiver.java:91)
	at com.faforever.client.login.OAuthValuesReceiver.lambda$receiveValues$0(OAuthValuesReceiver.java:52)
	at java.base/java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1768)
	at java.base/java.util.concurrent.CompletableFuture$AsyncSupply.exec(CompletableFuture.java:1760)
	at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:387)
	at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1312)
	at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1843)
	at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1808)
	at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:188)

image

OS
Windows

@obydog002
Copy link
Contributor

Cant reproduce on FF with Linux

@micheljung
Copy link
Member

micheljung commented Jan 8, 2024

Does the URL really contain http:// or https://? Because it looks like encrypted data being sent to an HTTP port.

Browsers may redirect you to HTTPS if you ever visited a website via HTTPS. Google HSTS. AFAIK, Chrome only does this for hostnames, not IP-Adresses, but I'm not sure about this and I don't know what Firefox does. Try deleting HSTS for 127.0.0.1 (or localhost) in Firefox

@Sheikah45
Copy link
Member

Hmmm yeah I guess that would explain the characters. I guess I never really expected browsers to redirect localhost to https since I thought the server normally controlled the redirects.

@Brutus5000
Copy link
Member

If this is the case it's kind of a no-win scenario. Even if we offer https the browser will complain because we can't offer a valid certificate...

@disconsented
Copy link
Author

Yep, my browser was going to HTTPS first due to the Smart HTTPS plugin, disable that, and it all works fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants