Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replay search is too complicated #739

Closed
JaggedAppliance opened this issue Feb 2, 2018 · 5 comments · Fixed by #2044
Closed

Replay search is too complicated #739

JaggedAppliance opened this issue Feb 2, 2018 · 5 comments · Fixed by #2044

Comments

@JaggedAppliance
Copy link

There are lots of essentially useless search terms and too many dropdown menus and items.

The python client search is much better, you have a field for player name, a field for map name, a dropdown to select the base mod(1v1ladder, faf, fafbeta, phantom etc.) and a field for minimum rating.

@1-alex98
Copy link
Member

1-alex98 commented Feb 3, 2018

Hmm you might have a point there, but maybe we would need a little more concrete suggestion on how to change.

@EmielWitteman
Copy link

I like the search ability with several criteria, but most users probably will only search for Player names and map names. Especially the "contains" filter is handy for obscure player and map names.
If the default criteria setting would be remembered and/or initialized with "Player name is " it will be more pleasant for most users I guess. Now the default criteria is "ID contains" which is less useful.

@micheljung
Copy link
Member

I think it's time to tackle this. @BlackYps already took a shot at it in #1805 but I'm not yet convinced.

IMO, one case of "filtering done right" can be seen on digitec.ch.

For instance, if you're looking for a graphics card, this is their filter:

e060ac60-0337-44d5-a0db-8cf73e0d1866

I think this is what we should aim for.

@BlackYps
Copy link
Collaborator

These filters are really nice for categories. Maybe we can use the CheckMenuItems for this. But we have to find a way to disable that the menu closes each time you select one Item. I also found this.

@JaggedAppliance
Copy link
Author

I'm glad this is being looked at. I like the power of the search in general, my hope is that common searches can be made much more quickly and with less clicks. Being able to save particular queries would be useful but if searching is made more efficient that won't be necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants