Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T1 Power Generator Simultaneous Explosion Inconsistency #4335

Closed
ChessBerry opened this issue Nov 5, 2022 · 10 comments
Closed

T1 Power Generator Simultaneous Explosion Inconsistency #4335

ChessBerry opened this issue Nov 5, 2022 · 10 comments
Labels
area: balance related to units balance

Comments

@ChessBerry
Copy link
Contributor

If you ctrl+k a bunch of adjacent t1 power generators, they sometimes deal damage to each other's wrecks, reducing the reclaim they leave behind. While well known, it seems that sera t1 pgens, and only sera t1 pgens are for some reason immune to that:

Aeon:
Screenshot_3

Uef (note the "16" mixed in with the "61"):
Screenshot_4

Cybran:
Screenshot_5

Sera:
Screenshot_6

Replay ID with these tests, no sim mods enabled: 18435210
This behavior was found by Femto Zetta on the discord.

While the bug report part of this issue is "sera t1 pgens op", this could actually be useful.

Afaik, the "pgens damaging their neighbors wrecks" behavior is effectively random, or at least it doesn't seem to depend on build order or ground geometry.
If we can figure out why the sera pgens don't do that, we could clone the behavior to the other factions pgens, removing a (minor) annoyance from the game.

From a very cursory examination of the collision boxes, I couldn't figure out any reason why sera t1 pgens behave differently though. In fact their collision box seems to be a duplicate of the UEF one(?), and if you believe the stats their death explosion is the same too:
Screenshot_7

Well, idk. Here is to another weird oddity in this game of ours :P

@ChessBerry ChessBerry added the status: new issue Is added to every issue to indicate that it has not been reviewed yet label Nov 5, 2022
@Garanas
Copy link
Member

Garanas commented Nov 5, 2022

image

Seraphim power generators have a small death animation that is played. Death animations in general have a strange interaction with their wrecks, as they are 'immune' for damage during the animation.

If we'd remove the death animation then we'd end up with floating little orbs:

image

But that does give us a similar pattern:

image

@Garanas Garanas added area: balance related to units balance and removed status: new issue Is added to every issue to indicate that it has not been reviewed yet labels Nov 5, 2022
@Garanas
Copy link
Member

Garanas commented Nov 5, 2022

This does matter in practice, as people often CTRL + K power generators to reclaim them quicker. This would be a lot more beneficial to do for Seraphim then for other factions.

@Garanas
Copy link
Member

Garanas commented Nov 5, 2022

Thinking about it, death animations on volatile structures should likely be removed - it can cause a lot of weirdness.

@ChessBerry
Copy link
Contributor Author

ChessBerry commented Nov 5, 2022

I'm not sure this really "matters" even on the highest level, on even the most sim-citiest of maps.
And personally I'd prefer to make the consistent behavior of sera pgens and not the random behavior of the other factions the default, but if that's infeasible or if that causes other problems, then the reverse is fine too.

(Sry for the close and reopening, I missclicked)

@ChessBerry ChessBerry reopened this Nov 5, 2022
@piisawheel
Copy link

From a balance point of view, Sera doesn't get rascoms and must rely on massfabs if the game type requires it. It could be considered balanced from that point of view. I have a (probably bad) habit of reclaiming live pgens, so this doesn't really affect me, as much as it should be affecting me.

@MrRowey
Copy link
Member

MrRowey commented Jun 18, 2023

@Garanas This has been discussed and the comment for this were as follows

- If we could make all behave like sera that would be best
- If not, then we’d like them to be as consistent as possible

@MrRowey MrRowey added this to the Balance iteration I milestone Jun 18, 2023
@Garanas
Copy link
Member

Garanas commented Jun 19, 2023

Then I'll make it consistent. We can't have them all behave like the Seraphim pgens.

@BlackYps
Copy link
Contributor

I don't really understand the conclusion here. It was mentioned that the seraphim pgens need the death animation to prevent the floating orb. And having the pgens not take damage is the more preferred way by the balance team. So why can't we give all pgens a small death animation?

@Garanas
Copy link
Member

Garanas commented Jun 25, 2023

The correct solution is not to give more structures death animations, but to allow structures to soak (splash) damage when their death animation is running and take that into account with the value of the wreck

@BlackYps
Copy link
Contributor

BlackYps commented Jul 2, 2023

So are we working in that direction or did we settle for removing the death animations? I agree with your take on what the correct solution should be, but earlier in this discussion you argued for removing the death animations. So I am getting some mixed signals here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: balance related to units balance
Projects
None yet
Development

No branches or pull requests

5 participants