Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Galactic colossus under construction hitbox incorrect #4470

Closed
maudlin27 opened this issue Dec 2, 2022 · 1 comment · Fixed by #5437
Closed

Galactic colossus under construction hitbox incorrect #4470

maudlin27 opened this issue Dec 2, 2022 · 1 comment · Fixed by #5437
Labels
area: sim Area that is affected by the Simulation of the Game good first issue issue that is relative easy to pick up type: bug

Comments

@maudlin27
Copy link
Contributor

Summary:
A galactic colossus was given an attack order on an enemy GC that was under construction, the firing GC's beam went through the under construction GC and hit the ground behind it. This happened from several angles. I'm assuming the issue is connected with the hitbox of the GC or the change made a number of months ago for GC and Aeon units being constructed.

Screenshots:
In both the below examples the GC was firing for a number of seconds (with an attack order having been given):
GC Shot1

GC shot 2

Other:
Observed in a human vs AI game, not sure on the replay number now but as it was late on in a game that runs at -2 at times (with a good CPU) so I expect it'd be much faster to recreate in sandbox than to view the replay.

@maudlin27 maudlin27 added the status: new issue Is added to every issue to indicate that it has not been reviewed yet label Dec 2, 2022
@Garanas Garanas added type: bug area: sim Area that is affected by the Simulation of the Game and removed status: new issue Is added to every issue to indicate that it has not been reviewed yet labels Dec 14, 2022
@Garanas
Copy link
Member

Garanas commented Dec 14, 2022

image

Appears this needs a similar fix like we did with the megalith in #4102: we manually adjusted the collision box during construction and then restore it when the unit is complete.

@xXEddieXxx could I encourage you to pick this up? Note that there are two different build animations.

The hotkeys you can use are:

  • CTRL + ALT + SHIFT + C: show collision boxes
  • ALT + V : show bones
  • ALT + B: show bone names

The goal would be to have a collision box that fits both build animations from start to finish, initially it will likely extend over the colossus quite a bit - that is fine. That is what it is like now too.

And note that this function exists:

@Garanas Garanas added the good first issue issue that is relative easy to pick up label Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: sim Area that is affected by the Simulation of the Game good first issue issue that is relative easy to pick up type: bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants