Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix treadmarks #4656

Open
BlackYps opened this issue Jan 29, 2023 · 3 comments
Open

Fix treadmarks #4656

BlackYps opened this issue Jan 29, 2023 · 3 comments
Labels
area: graphics Anything Related to the Game Graphics area: unit-blueprint related to issues in unit blueprints (*_unit.bp) good first issue issue that is relative easy to pick up status: new issue Is added to every issue to indicate that it has not been reviewed yet

Comments

@BlackYps
Copy link
Contributor

Describe the bug
A lot of units don't leave a continuous line of treadmarks anymore as their speed has been adjusted at some point.

The TreadMarksInterval value in a unit's blueprint determines how often treadmarks get spawned. These need to be adjusted.
https://github.com/FAForever/fa/blob/develop/units/UEL0201/UEL0201_unit.bp#L92

To Reproduce
Watch units closely as they move on the ground

Expected behavior
The treadmarks should be spawned at a rate that produces a continuous line when the unit is travelling at full speed.

To fix
The units with problems need to be identified and then fixed. There might be a way to automate this by looking at the Treadmarksize and the speed of the unit, but visually hunting for units and then adjusting the value by eyeballing the result works as well.
It's probably a good idea to not wait to fix all of them, but to already open a pull request when you fixed a handful of units.

Screenshots
grafik

@BlackYps BlackYps added good first issue issue that is relative easy to pick up status: new issue Is added to every issue to indicate that it has not been reviewed yet area: graphics Anything Related to the Game Graphics area: unit-blueprint related to issues in unit blueprints (*_unit.bp) labels Jan 29, 2023
@Garanas
Copy link
Member

Garanas commented Jan 30, 2023

The screenshot appears to be taken from: #4640

Have you checked the status on FAFDevelop for this? I noticed the same thing, and tried to fix it. It looks like this:

image

It was due to a +1 in the WaitSeconds function, but we now use the WaitTicks function.

@Garanas
Copy link
Member

Garanas commented Jan 30, 2023

Which brings me back to @speed2CZ , it is likely better to not add that +1 everywhere.

@BlackYps
Copy link
Contributor Author

BlackYps commented Feb 1, 2023

I can confirm that some units are fixed on fafdevelop. But there are still units that have issues with their treadmarks. For example all UEF mobile antiair has noticeable gaps, so this issue is still relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: graphics Anything Related to the Game Graphics area: unit-blueprint related to issues in unit blueprints (*_unit.bp) good first issue issue that is relative easy to pick up status: new issue Is added to every issue to indicate that it has not been reviewed yet
Projects
None yet
Development

No branches or pull requests

2 participants