Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use UTF-8 encoding for main protocol #132

Closed
Sheeo opened this issue May 15, 2016 · 2 comments
Closed

Use UTF-8 encoding for main protocol #132

Sheeo opened this issue May 15, 2016 · 2 comments
Milestone

Comments

@Sheeo
Copy link
Member

Sheeo commented May 15, 2016

Currently the protocol uses a QDataStream compatible format, which implies text is encoded as UTF-16BE.

Since most of our data is English text, this means we incur an unnecessary 50% space overhead, and a small amount of conversion, for every message. For slow clients (Both in terms of processing and link-speed) this can especially be a problem.

Acceptance Criteria

  • Protocol uses plain UTF-8 encoded JSON with no other binary elements.

Tips to get started

  • The protocol encoding is currently performed entirely by this
  • Replace this with a different implementation that only uses UTF-8 and doesn't bother with legacy encoded messages
  • Make sure to update explicit uses of QDataStreamProtocol, such as here
@Sheeo Sheeo added this to the v1.0 milestone May 15, 2016
@Sheeo
Copy link
Member Author

Sheeo commented May 15, 2016

See #124

@Askaholic
Copy link
Collaborator

This was added in #615. The UTF8 encoded version of the protocol is available over a second port.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants