Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ladder game not reported right #255

Closed
GrotheFAF opened this issue Dec 5, 2016 · 14 comments
Closed

ladder game not reported right #255

GrotheFAF opened this issue Dec 5, 2016 · 14 comments
Assignees
@micheljung
Labels
in progress

Comments

@GrotheFAF
Copy link

ladder game #5497983 is shown and counted like both players lost, but I actually won.
(the server stored replay look right, but shows no score at the end.)
forever.zip
@micheljung
Copy link
Member 

mysql> select * from game_player_stats where gameid = 5497983;
+----------+---------+----------+----+---------+-------+------+-------+---------+-----------+------------+-----------------+-------+---------------------+
| id       | gameId  | playerId | AI | faction | color | team | place | mean    | deviation | after_mean | after_deviation | score | scoreTime           |
+----------+---------+----------+----+---------+-------+------+-------+---------+-----------+------------+-----------------+-------+---------------------+
| 10242620 | 5497983 |   112924 |  0 |       1 |     1 |    1 |     1 | 786.982 |   66.0333 |    789.799 |          65.582 |     0 | 2016-12-05 07:10:50 |
| 10242621 | 5497983 |    86430 |  0 |       1 |     2 |    1 |     2 | 865.812 |   66.6863 |     862.94 |         66.1922 |     0 | 2016-12-05 07:10:50 |
+----------+---------+----------+----+---------+-------+------+-------+---------+-----------+------------+-----------------+-------+---------------------+

@micheljung
Copy link
Member

micheljung commented Dec 6, 2016 •
edited

Grothe the log says you got disconnected from the server twice, after you died:

2016-12-05 08:10:42,696 INFO     client._clientwindow           Outgoing JSON Message: {"args": [], "command": "EnforceRating", "target": "game"}
2016-12-05 08:10:42,742 INFO     client._clientwindow           Timeout/network error: The remote host closed the connection
2016-12-05 08:10:42,742 WARNING  client._clientwindow           Disconnected from lobby server.
2016-12-05 08:10:42,742 INFO     client._clientwindow           Reconnecting immediately
2016-12-05 08:10:42,742 WARNING  client._clientwindow           Disconnected from lobby server.
2016-12-05 08:10:42,742 INFO     client._clientwindow           Reconnecting immediately
2016-12-05 08:10:42,821 INFO     client._clientwindow           Outgoing JSON Message: {"version": "0.11.61-pre2-24-gcb14d90\n", "command": "ask_session", "user_agent": "faf-client"}
2016-12-05 08:10:42,835 INFO     fa.game_connection.GPGNetConnection GC >> : GameResult : [1, u'score 1']
2016-12-05 08:10:42,835 INFO     fa.game_session.GameSession    Incoming GPGNet: GameResult [1, u'score 1']
2016-12-05 08:10:42,835 INFO     fa.game_session.GameSession    Outgoing relay message GameResult [1, u'score 1']
2016-12-05 08:10:42,835 INFO     client._clientwindow           Outgoing JSON Message: {"args": [1, "score 1"], "command": "GameResult", "target": "game"}
2016-12-05 08:10:46,868 INFO     client._clientwindow           Logging in with {'login': u'Grothe', 'session': '2655603029', 'command': 'hello', 'unique_id': 'B1dGRDNBZFc3SjZLNVdqNUNGWXBjdkE9PXFkd1dPRGM3UmhXTFZPTnFlMzJCa1JhUmlVY04wdEV2RlIyOW5uQXlGZlI5d3VnZDYzK1pyeFMxRmJOVmNmNHZvTnRUMWk1R2puR2E1RWI2aGVyZHlzNlhkeVQ5UlhMajRHK05xa1U5YkNZaVBOd2lPdTN4L01CUTRySmtUTkJQKzZ3dnd1em8rMlhPMUtsUG8wU3B6YXJJY29NQzhQQjJFTDZ6azF0OWxncThpSWw2b3ZZQnNrSE1hWm50bllQQTF1d3o5SUxZQkloMmtwK0UxOFpubXBhR0JjOHhXeUw3MjZIbmxGQmJrZWJQL2tUSVpFbEE3aHhKSUVkTm9ITWowYXZFNFJ1blZjZGh3aEZZbzkzOXJGVHlVUGhjNUxzVGYxNUFZcDZ0a1BIU0p6RjJkNitTTitydEZ4TTVRbnVyS0ZQNkl6RmdrV0cwR09ueHo2UEx1OHFQeHh6ZlYrU2JzaHk2a3BhNVN2R1FCZ1ZmbTZYZFNrMExkOEFHRExiSHV4ZEFubWNaYkVKWWVBcHU2Y3BZbnZ3MlN1ZkZmNVFpTGQ5MDRQejNlYm03M01Mek9jY3QrLzhGK2ZGVUk4NGNOZmFZN25XVHZlSUs0aVB4WU4zZUNmb1BocUY5enRDMlZ5OVNBWGl2WVVtSHJxNmNaUXo3RzVwM3BhR0Flb2JHL2RHVW1PNEdpNlpUWXRnTFg1UkxsNEQ4VFFBaEcrQmQrUkRxVEt3OHpNaTlobGFsaHdTZ21ZTGNvMmtqOFNLekZvb2Y2cW1Bd3pPRnZPT2R1aHdpK29GQTlVenN2WFA2b3I0eUVPdGxLRUkzV0RGbEpGMFczcXpDZ3d2YU1vTHIyb0dIUitZSzVXdnMyU1E2YkRzaUl2TTZNMXEzTXBDN2FrTmNMUkw5MVZKeU1iQTJUWmw2Z0k0VTFSY1pCdHQzdnI1Z0JQYWpSS01RdEd3MVZ1emJON0R4bk1JcXJjVU5IWW1rUFEydklNTU4zNld0OXZmY1krakR6ZWYyMHNadHUzSEVXS0d3aTVCQmdzZi94Wk1aK3ZOWmNKZGpvYTJXc25VUUV0RU9iS3BUWVZvU3VXTTl0OENIV2FjVlVrdXZnUDY1S3A2SUhWU0ozQ2FzNUdkWUVrYzBIS2l1cW9DRW5CSDIwRkF5dkJXeTRsRC9tK21qajdRSzRTRXY0ZXlzT0pFL2gzSmVZTVNIT3RtTktLbG16R3dCQUxDWFhKUFB4Vmx3WVg2T0VxdkhQVjZuMlhzUUxFZTRteXhjek9RMC8vTThreWRMUkdyUHBjNTZMZUNxRlJRenUzbHFDQ2ZwT0VldHRSSEZOZmc9QjM1KzdaSXN0Wi9WSis2RlR2WDNFU2ZEaDRBNHU5L1pyK2VQQ2c9PQ=='}
2016-12-05 08:10:46,868 INFO     client._clientwindow           Timeout/network error: The remote host closed the connection
2016-12-05 08:10:46,868 WARNING  client._clientwindow           Disconnected from lobby server.
2016-12-05 08:10:46,882 INFO     client._clientwindow           Scheduling reconnect in 20
2016-12-05 08:10:46,882 WARNING  client._clientwindow           Disconnected from lobby server.
2016-12-05 08:10:46,882 INFO     client._clientwindow           Scheduling reconnect in 20
2016-12-05 08:10:48,085 INFO     fa.game_connection.GPGNetConnection GC >> : GameResult : [2, u'defeat -10']
2016-12-05 08:10:48,085 INFO     fa.game_session.GameSession    Incoming GPGNet: GameResult [2, u'defeat -10']
2016-12-05 08:10:48,085 INFO     fa.game_session.GameSession    Outgoing relay message GameResult [2, u'defeat -10']
2016-12-05 08:10:48,085 INFO     client._clientwindow           Outgoing JSON Message: {"args": [2, "defeat -10"], "command": "GameResult", "target": "game"}
2016-12-05 08:10:50,148 INFO     fa.game_connection.GPGNetConnection GC >> : JsonStats : [u'{"stats":[{"blueprints":{"ueb1201":{"built":1},"ueb0101":{"kills":8,"built":11},"dea0202":{"built":2},"uel0104":{"lost":14,"kills":4,"built":19},"uel0208":{"built":2},"uea0203":{"built":2},"uea0101":{"lost":2,"built":4},"ueb2104":{"kills":3},"uel0106":{"lost":1,"built":2},"ueb1101":{"lost":2,"kills":5,"built":20},"uel0202":{"lost":4,"built":19},"ueb1103":{"lost":2,"kills":14,"built":17},"uel0201":{"lost":178,"kills":131,"built":215},"ueb0202":{"built":1},"ueb1102":{"built":1},"ueb1105":{"kills":1,"built":1},"uea0107":{"kills":2},"ueb0201":{"built":1},"uel0111":{"lost":5,"built":5},"ueb3101":{"kills":3,"built":2},"ueb1202":{"built":8},"uel0105":{"lost":5,"kills":35,"built":29},"uea0102":{"lost":1,"kills":3,"built":12},"zeb9501":{"built":4},"ueb0102":{"built":2},"uea0103":{"lost":2,"kills":6,"built":11},"del0204":{"built":4},"ueb2101":{"kills":8},"uel0001":{"kills":1,"built":1,"lowest_health":6127},"uel0101":{"lost":22,"built":25},"ueb1106":{"built":5},"uel0103":{"lost":60,"kills":61,"built":76},"uel0205":{"built":3}},"type":"Human","general":{"score":40021,"currentcap":{"count":1000},"lastReclaimedMass":9073.68359375,"kills":{"mass":37599.23828125,"count":307,"energy":5149330},"built":{"mass":46948,"count":505,"energy":361915},"lastReclaimedEnergy":9884.3125,"lost":{"mass":17656.75,"count":312,"energy":131925.5},"energy":539523.9375,"currentunits":{"count":192},"mass":46600.25},"faction":1,"resources":{"massin":{"total":46600.25,"rate":6.8749995231628},"energyover":85497.265625,"energyin":{"total":539523.9375,"rate":98},"energyout":{"total":445011.09375,"rate":73.211479187012},"massover":506.07427978516,"massout":{"total":44979.5,"rate":7.8024988174438}},"name":"Grothe","units":{"air":{"lost":19,"kills":13,"built":34},"tech3":{"lost":0,"kills":0,"built":0},"cdr":{"lost":0,"kills":1,"built":1},"tech2":{"lost":11,"kills":0,"built":52},"tech1":{"lost":301,"kills":306,"built":452},"transportation":{"lost":0,"kills":2,"built":2},"land":{"lost":289,"kills":256,"built":416},"experimental":{"lost":0,"kills":0,"built":0},"structures":{"lost":4,"kills":47,"built":74},"engineer":{"lost":5,"kills":41,"built":32},"naval":{"lost":0,"kills":0,"built":0},"sacu":{"lost":0,"kills":0,"built":0}}},{"blueprints":{"ueb1102":{"built":1},"ueb1105":{"lost":2,"built":6},"uea0107":{"lost":1,"built":2},"ueb0101":{"lost":9,"built":22},"dea0202":{"kills":2},"uel0111":{"kills":5},"uel0104":{"lost":4,"kills":13,"built":5},"ueb3101":{"lost":4,"built":5},"ueb1202":{"built":2},"uel0001":{"lost":1,"built":1,"lowest_health":0},"uel0105":{"lost":42,"kills":4,"built":72},"ueb2104":{"lost":3,"built":8},"uel0106":{"kills":1},"ueb1101":{"lost":7,"kills":2,"built":24},"uel0202":{"kills":4},"ueb0102":{"built":2},"ueb2101":{"lost":12,"built":13},"ueb1103":{"lost":14,"kills":1,"built":30},"uea0102":{"lost":2,"kills":5,"built":6},"uea0103":{"kills":10,"built":7},"uel0101":{"kills":22},"uel0201":{"lost":145,"kills":171,"built":150},"uel0103":{"lost":68,"kills":59,"built":82},"uea0101":{"kills":1}},"type":"Human","general":{"score":27394,"currentcap":{"count":1000},"lastReclaimedMass":6482.9541015625,"kills":{"mass":17656.75,"count":312,"energy":131925.5},"built":{"mass":33536,"count":438,"energy":255205},"lastReclaimedEnergy":14605.770507813,"lost":{"mass":38639.859375,"count":324,"energy":5155457},"energy":389118.96875,"currentunits":{"count":141},"mass":36925.046875},"faction":1,"resources":{"massin":{"total":36925.046875,"rate":2.1475491523743},"energyover":30377.583984375,"energyin":{"total":389118.96875,"rate":44},"energyout":{"total":358752.625,"rate":43.999988555908},"massover":5.5986328125,"massout":{"total":36851.390625,"rate":5.5889530181885}},"name":"bobbuild","units":{"air":{"lost":13,"kills":19,"built":17},"tech3":{"lost":0,"kills":0,"built":0},"cdr":{"lost":1,"kills":0,"built":1},"tech2":{"lost":0,"kills":11,"built":2},"tech1":{"lost":323,"kills":301,"built":435},"transportation":{"lost":2,"kills":0,"built":2},"land":{"lost":269,"kills":289,"built":332},"experimental":{"lost":0,"kills":0,"built":0},"structures":{"lost":51,"kills":4,"built":113},"engineer":{"lost":43,"kills":5,"built":73},"naval":{"lost":0,"kills":0,"built":0},"sacu":{"lost":0,"kills":0,"built":0}}},{"blueprints":[],"type":"AI","general":{"score":0,"currentcap":{"count":1000},"lastReclaimedMass":0,"kills":{"mass":0,"count":0,"energy":0},"built":{"mass":0,"count":0,"energy":0},"lastReclaimedEnergy":0,"lost":{"mass":0,"count":0,"energy":0},"energy":0,"currentunits":{"count":0},"mass":0},"faction":5,"resources":{"massin":{"total":0,"rate":0},"energyover":0,"energyin":{"total":0,"rate":0},"energyout":{"total":0,"rate":0},"massover":0,"massout":{"total":0,"rate":0}},"name":"civilian","units":{"air":{"lost":0,"kills":0,"built":0},"tech3":{"lost":0,"kills":0,"built":0},"cdr":{"lost":0,"kills":0,"built":0},"tech2":{"lost":0,"kills":0,"built":0},"tech1":{"lost":0,"kills":0,"built":0},"transportation":{"lost":0,"kills":0,"built":0},"land":{"lost":0,"kills":0,"built":0},"experimental":{"lost":0,"kills":0,"built":0},"structures":{"lost":0,"kills":0,"built":0},"engineer":{"lost":0,"kills":0,"built":0},"naval":{"lost":0,"kills":0,"built":0},"sacu":{"lost":0,"kills":0,"built":0}}},{"blueprints":{"urc1301":{"built":3},"urc1101":{"built":5},"urc1201":{"built":2},"urc1401":{"built":4},"urc1501":{"built":7},"urb5101":{"built":293}},"type":"AI","general":{"score":0,"currentcap":{"count":1000},"lastReclaimedMass":0,"kills":{"mass":0,"count":0,"energy":0},"built":{"mass":0,"count":314,"energy":0},"lastReclaimedEnergy":0,"lost":{"mass":0,"count":0,"energy":0},"energy":0,"currentunits":{"count":0},"mass":0},"faction":5,"resources":{"massin":{"total":0,"rate":0},"energyover":0,"energyin":{"total":0,"rate":0},"energyout":{"total":0,"rate":0},"massover":0,"massout":{"total":0,"rate":0}},"name":"civilian","units":{"air":{"lost":0,"kills":0,"built":0},"tech3":{"lost":0,"kills":0,"built":0},"cdr":{"lost":0,"kills":0,"built":0},"tech2":{"lost":0,"kills":0,"built":0},"tech1":{"lost":0,"kills":0,"built":293},"transportation":{"lost":0,"kills":0,"built":0},"land":{"lost":0,"kills":0,"built":21},"experimental":{"lost":0,"kills":0,"built":0},"structures":{"lost":0,"kills":0,"built":314},"engineer":{"lost":0,"kills":0,"built":0},"naval":{"lost":0,"kills":0,"built":0},"sacu":{"lost":0,"kills":0,"built":0}}}]}']
2016-12-05 08:10:50,148 INFO     fa.game_session.GameSession    Incoming GPGNet: JsonStats [u'{"stats":[{"blueprints":{"ueb1201":{"built":1},"ueb0101":{"kills":8,"built":11},"dea0202":{"built":2},"uel0104":{"lost":14,"kills":4,"built":19},"uel0208":{"built":2},"uea0203":{"built":2},"uea0101":{"lost":2,"built":4},"ueb2104":{"kills":3},"uel0106":{"lost":1,"built":2},"ueb1101":{"lost":2,"kills":5,"built":20},"uel0202":{"lost":4,"built":19},"ueb1103":{"lost":2,"kills":14,"built":17},"uel0201":{"lost":178,"kills":131,"built":215},"ueb0202":{"built":1},"ueb1102":{"built":1},"ueb1105":{"kills":1,"built":1},"uea0107":{"kills":2},"ueb0201":{"built":1},"uel0111":{"lost":5,"built":5},"ueb3101":{"kills":3,"built":2},"ueb1202":{"built":8},"uel0105":{"lost":5,"kills":35,"built":29},"uea0102":{"lost":1,"kills":3,"built":12},"zeb9501":{"built":4},"ueb0102":{"built":2},"uea0103":{"lost":2,"kills":6,"built":11},"del0204":{"built":4},"ueb2101":{"kills":8},"uel0001":{"kills":1,"built":1,"lowest_health":6127},"uel0101":{"lost":22,"built":25},"ueb1106":{"built":5},"uel0103":{"lost":60,"kills":61,"built":76},"uel0205":{"built":3}},"type":"Human","general":{"score":40021,"currentcap":{"count":1000},"lastReclaimedMass":9073.68359375,"kills":{"mass":37599.23828125,"count":307,"energy":5149330},"built":{"mass":46948,"count":505,"energy":361915},"lastReclaimedEnergy":9884.3125,"lost":{"mass":17656.75,"count":312,"energy":131925.5},"energy":539523.9375,"currentunits":{"count":192},"mass":46600.25},"faction":1,"resources":{"massin":{"total":46600.25,"rate":6.8749995231628},"energyover":85497.265625,"energyin":{"total":539523.9375,"rate":98},"energyout":{"total":445011.09375,"rate":73.211479187012},"massover":506.07427978516,"massout":{"total":44979.5,"rate":7.8024988174438}},"name":"Grothe","units":{"air":{"lost":19,"kills":13,"built":34},"tech3":{"lost":0,"kills":0,"built":0},"cdr":{"lost":0,"kills":1,"built":1},"tech2":{"lost":11,"kills":0,"built":52},"tech1":{"lost":301,"kills":306,"built":452},"transportation":{"lost":0,"kills":2,"built":2},"land":{"lost":289,"kills":256,"built":416},"experimental":{"lost":0,"kills":0,"built":0},"structures":{"lost":4,"kills":47,"built":74},"engineer":{"lost":5,"kills":41,"built":32},"naval":{"lost":0,"kills":0,"built":0},"sacu":{"lost":0,"kills":0,"built":0}}},{"blueprints":{"ueb1102":{"built":1},"ueb1105":{"lost":2,"built":6},"uea0107":{"lost":1,"built":2},"ueb0101":{"lost":9,"built":22},"dea0202":{"kills":2},"uel0111":{"kills":5},"uel0104":{"lost":4,"kills":13,"built":5},"ueb3101":{"lost":4,"built":5},"ueb1202":{"built":2},"uel0001":{"lost":1,"built":1,"lowest_health":0},"uel0105":{"lost":42,"kills":4,"built":72},"ueb2104":{"lost":3,"built":8},"uel0106":{"kills":1},"ueb1101":{"lost":7,"kills":2,"built":24},"uel0202":{"kills":4},"ueb0102":{"built":2},"ueb2101":{"lost":12,"built":13},"ueb1103":{"lost":14,"kills":1,"built":30},"uea0102":{"lost":2,"kills":5,"built":6},"uea0103":{"kills":10,"built":7},"uel0101":{"kills":22},"uel0201":{"lost":145,"kills":171,"built":150},"uel0103":{"lost":68,"kills":59,"built":82},"uea0101":{"kills":1}},"type":"Human","general":{"score":27394,"currentcap":{"count":1000},"lastReclaimedMass":6482.9541015625,"kills":{"mass":17656.75,"count":312,"energy":131925.5},"built":{"mass":33536,"count":438,"energy":255205},"lastReclaimedEnergy":14605.770507813,"lost":{"mass":38639.859375,"count":324,"energy":5155457},"energy":389118.96875,"currentunits":{"count":141},"mass":36925.046875},"faction":1,"resources":{"massin":{"total":36925.046875,"rate":2.1475491523743},"energyover":30377.583984375,"energyin":{"total":389118.96875,"rate":44},"energyout":{"total":358752.625,"rate":43.999988555908},"massover":5.5986328125,"massout":{"total":36851.390625,"rate":5.5889530181885}},"name":"bobbuild","units":{"air":{"lost":13,"kills":19,"built":17},"tech3":{"lost":0,"kills":0,"built":0},"cdr":{"lost":1,"kills":0,"built":1},"tech2":{"lost":0,"kills":11,"built":2},"tech1":{"lost":323,"kills":301,"built":435},"transportation":{"lost":2,"kills":0,"built":2},"land":{"lost":269,"kills":289,"built":332},"experimental":{"lost":0,"kills":0,"built":0},"structures":{"lost":51,"kills":4,"built":113},"engineer":{"lost":43,"kills":5,"built":73},"naval":{"lost":0,"kills":0,"built":0},"sacu":{"lost":0,"kills":0,"built":0}}},{"blueprints":[],"type":"AI","general":{"score":0,"currentcap":{"count":1000},"lastReclaimedMass":0,"kills":{"mass":0,"count":0,"energy":0},"built":{"mass":0,"count":0,"energy":0},"lastReclaimedEnergy":0,"lost":{"mass":0,"count":0,"energy":0},"energy":0,"currentunits":{"count":0},"mass":0},"faction":5,"resources":{"massin":{"total":0,"rate":0},"energyover":0,"energyin":{"total":0,"rate":0},"energyout":{"total":0,"rate":0},"massover":0,"massout":{"total":0,"rate":0}},"name":"civilian","units":{"air":{"lost":0,"kills":0,"built":0},"tech3":{"lost":0,"kills":0,"built":0},"cdr":{"lost":0,"kills":0,"built":0},"tech2":{"lost":0,"kills":0,"built":0},"tech1":{"lost":0,"kills":0,"built":0},"transportation":{"lost":0,"kills":0,"built":0},"land":{"lost":0,"kills":0,"built":0},"experimental":{"lost":0,"kills":0,"built":0},"structures":{"lost":0,"kills":0,"built":0},"engineer":{"lost":0,"kills":0,"built":0},"naval":{"lost":0,"kills":0,"built":0},"sacu":{"lost":0,"kills":0,"built":0}}},{"blueprints":{"urc1301":{"built":3},"urc1101":{"built":5},"urc1201":{"built":2},"urc1401":{"built":4},"urc1501":{"built":7},"urb5101":{"built":293}},"type":"AI","general":{"score":0,"currentcap":{"count":1000},"lastReclaimedMass":0,"kills":{"mass":0,"count":0,"energy":0},"built":{"mass":0,"count":314,"energy":0},"lastReclaimedEnergy":0,"lost":{"mass":0,"count":0,"energy":0},"energy":0,"currentunits":{"count":0},"mass":0},"faction":5,"resources":{"massin":{"total":0,"rate":0},"energyover":0,"energyin":{"total":0,"rate":0},"energyout":{"total":0,"rate":0},"massover":0,"massout":{"total":0,"rate":0}},"name":"civilian","units":{"air":{"lost":0,"kills":0,"built":0},"tech3":{"lost":0,"kills":0,"built":0},"cdr":{"lost":0,"kills":0,"built":0},"tech2":{"lost":0,"kills":0,"built":0},"tech1":{"lost":0,"kills":0,"built":293},"transportation":{"lost":0,"kills":0,"built":0},"land":{"lost":0,"kills":0,"built":21},"experimental":{"lost":0,"kills":0,"built":0},"structures":{"lost":0,"kills":0,"built":314},"engineer":{"lost":0,"kills":0,"built":0},"naval":{"lost":0,"kills":0,"built":0},"sacu":{"lost":0,"kills":0,"built":0}}}]}']
2016-12-05 08:10:50,148 INFO     fa.game_session.GameSession    Outgoing relay message JsonStats [u'{"stats":[{"blueprints":{"ueb1201":{"built":1},"ueb0101":{"kills":8,"built":11},"dea0202":{"built":2},"uel0104":{"lost":14,"kills":4,"built":19},"uel0208":{"built":2},"uea0203":{"built":2},"uea0101":{"lost":2,"built":4},"ueb2104":{"kills":3},"uel0106":{"lost":1,"built":2},"ueb1101":{"lost":2,"kills":5,"built":20},"uel0202":{"lost":4,"built":19},"ueb1103":{"lost":2,"kills":14,"built":17},"uel0201":{"lost":178,"kills":131,"built":215},"ueb0202":{"built":1},"ueb1102":{"built":1},"ueb1105":{"kills":1,"built":1},"uea0107":{"kills":2},"ueb0201":{"built":1},"uel0111":{"lost":5,"built":5},"ueb3101":{"kills":3,"built":2},"ueb1202":{"built":8},"uel0105":{"lost":5,"kills":35,"built":29},"uea0102":{"lost":1,"kills":3,"built":12},"zeb9501":{"built":4},"ueb0102":{"built":2},"uea0103":{"lost":2,"kills":6,"built":11},"del0204":{"built":4},"ueb2101":{"kills":8},"uel0001":{"kills":1,"built":1,"lowest_health":6127},"uel0101":{"lost":22,"built":25},"ueb1106":{"built":5},"uel0103":{"lost":60,"kills":61,"built":76},"uel0205":{"built":3}},"type":"Human","general":{"score":40021,"currentcap":{"count":1000},"lastReclaimedMass":9073.68359375,"kills":{"mass":37599.23828125,"count":307,"energy":5149330},"built":{"mass":46948,"count":505,"energy":361915},"lastReclaimedEnergy":9884.3125,"lost":{"mass":17656.75,"count":312,"energy":131925.5},"energy":539523.9375,"currentunits":{"count":192},"mass":46600.25},"faction":1,"resources":{"massin":{"total":46600.25,"rate":6.8749995231628},"energyover":85497.265625,"energyin":{"total":539523.9375,"rate":98},"energyout":{"total":445011.09375,"rate":73.211479187012},"massover":506.07427978516,"massout":{"total":44979.5,"rate":7.8024988174438}},"name":"Grothe","units":{"air":{"lost":19,"kills":13,"built":34},"tech3":{"lost":0,"kills":0,"built":0},"cdr":{"lost":0,"kills":1,"built":1},"tech2":{"lost":11,"kills":0,"built":52},"tech1":{"lost":301,"kills":306,"built":452},"transportation":{"lost":0,"kills":2,"built":2},"land":{"lost":289,"kills":256,"built":416},"experimental":{"lost":0,"kills":0,"built":0},"structures":{"lost":4,"kills":47,"built":74},"engineer":{"lost":5,"kills":41,"built":32},"naval":{"lost":0,"kills":0,"built":0},"sacu":{"lost":0,"kills":0,"built":0}}},{"blueprints":{"ueb1102":{"built":1},"ueb1105":{"lost":2,"built":6},"uea0107":{"lost":1,"built":2},"ueb0101":{"lost":9,"built":22},"dea0202":{"kills":2},"uel0111":{"kills":5},"uel0104":{"lost":4,"kills":13,"built":5},"ueb3101":{"lost":4,"built":5},"ueb1202":{"built":2},"uel0001":{"lost":1,"built":1,"lowest_health":0},"uel0105":{"lost":42,"kills":4,"built":72},"ueb2104":{"lost":3,"built":8},"uel0106":{"kills":1},"ueb1101":{"lost":7,"kills":2,"built":24},"uel0202":{"kills":4},"ueb0102":{"built":2},"ueb2101":{"lost":12,"built":13},"ueb1103":{"lost":14,"kills":1,"built":30},"uea0102":{"lost":2,"kills":5,"built":6},"uea0103":{"kills":10,"built":7},"uel0101":{"kills":22},"uel0201":{"lost":145,"kills":171,"built":150},"uel0103":{"lost":68,"kills":59,"built":82},"uea0101":{"kills":1}},"type":"Human","general":{"score":27394,"currentcap":{"count":1000},"lastReclaimedMass":6482.9541015625,"kills":{"mass":17656.75,"count":312,"energy":131925.5},"built":{"mass":33536,"count":438,"energy":255205},"lastReclaimedEnergy":14605.770507813,"lost":{"mass":38639.859375,"count":324,"energy":5155457},"energy":389118.96875,"currentunits":{"count":141},"mass":36925.046875},"faction":1,"resources":{"massin":{"total":36925.046875,"rate":2.1475491523743},"energyover":30377.583984375,"energyin":{"total":389118.96875,"rate":44},"energyout":{"total":358752.625,"rate":43.999988555908},"massover":5.5986328125,"massout":{"total":36851.390625,"rate":5.5889530181885}},"name":"bobbuild","units":{"air":{"lost":13,"kills":19,"built":17},"tech3":{"lost":0,"kills":0,"built":0},"cdr":{"lost":1,"kills":0,"built":1},"tech2":{"lost":0,"kills":11,"built":2},"tech1":{"lost":323,"kills":301,"built":435},"transportation":{"lost":2,"kills":0,"built":2},"land":{"lost":269,"kills":289,"built":332},"experimental":{"lost":0,"kills":0,"built":0},"structures":{"lost":51,"kills":4,"built":113},"engineer":{"lost":43,"kills":5,"built":73},"naval":{"lost":0,"kills":0,"built":0},"sacu":{"lost":0,"kills":0,"built":0}}},{"blueprints":[],"type":"AI","general":{"score":0,"currentcap":{"count":1000},"lastReclaimedMass":0,"kills":{"mass":0,"count":0,"energy":0},"built":{"mass":0,"count":0,"energy":0},"lastReclaimedEnergy":0,"lost":{"mass":0,"count":0,"energy":0},"energy":0,"currentunits":{"count":0},"mass":0},"faction":5,"resources":{"massin":{"total":0,"rate":0},"energyover":0,"energyin":{"total":0,"rate":0},"energyout":{"total":0,"rate":0},"massover":0,"massout":{"total":0,"rate":0}},"name":"civilian","units":{"air":{"lost":0,"kills":0,"built":0},"tech3":{"lost":0,"kills":0,"built":0},"cdr":{"lost":0,"kills":0,"built":0},"tech2":{"lost":0,"kills":0,"built":0},"tech1":{"lost":0,"kills":0,"built":0},"transportation":{"lost":0,"kills":0,"built":0},"land":{"lost":0,"kills":0,"built":0},"experimental":{"lost":0,"kills":0,"built":0},"structures":{"lost":0,"kills":0,"built":0},"engineer":{"lost":0,"kills":0,"built":0},"naval":{"lost":0,"kills":0,"built":0},"sacu":{"lost":0,"kills":0,"built":0}}},{"blueprints":{"urc1301":{"built":3},"urc1101":{"built":5},"urc1201":{"built":2},"urc1401":{"built":4},"urc1501":{"built":7},"urb5101":{"built":293}},"type":"AI","general":{"score":0,"currentcap":{"count":1000},"lastReclaimedMass":0,"kills":{"mass":0,"count":0,"energy":0},"built":{"mass":0,"count":314,"energy":0},"lastReclaimedEnergy":0,"lost":{"mass":0,"count":0,"energy":0},"energy":0,"currentunits":{"count":0},"mass":0},"faction":5,"resources":{"massin":{"total":0,"rate":0},"energyover":0,"energyin":{"total":0,"rate":0},"energyout":{"total":0,"rate":0},"massover":0,"massout":{"total":0,"rate":0}},"name":"civilian","units":{"air":{"lost":0,"kills":0,"built":0},"tech3":{"lost":0,"kills":0,"built":0},"cdr":{"lost":0,"kills":0,"built":0},"tech2":{"lost":0,"kills":0,"built":0},"tech1":{"lost":0,"kills":0,"built":293},"transportation":{"lost":0,"kills":0,"built":0},"land":{"lost":0,"kills":0,"built":21},"experimental":{"lost":0,"kills":0,"built":0},"structures":{"lost":0,"kills":0,"built":314},"engineer":{"lost":0,"kills":0,"built":0},"naval":{"lost":0,"kills":0,"built":0},"sacu":{"lost":0,"kills":0,"built":0}}}]}']
2016-12-05 08:10:50,148 INFO     client._clientwindow           Outgoing JSON Message: {"args": ["{\"stats\":[{\"blueprints\":{\"ueb1201\":{\"built\":1},\"ueb0101\":{\"kills\":8,\"built\":11},\"dea0202\":{\"built\":2},\"uel0104\":{\"lost\":14,\"kills\":4,\"built\":19},\"uel0208\":{\"built\":2},\"uea0203\":{\"built\":2},\"uea0101\":{\"lost\":2,\"built\":4},\"ueb2104\":{\"kills\":3},\"uel0106\":{\"lost\":1,\"built\":2},\"ueb1101\":{\"lost\":2,\"kills\":5,\"built\":20},\"uel0202\":{\"lost\":4,\"built\":19},\"ueb1103\":{\"lost\":2,\"kills\":14,\"built\":17},\"uel0201\":{\"lost\":178,\"kills\":131,\"built\":215},\"ueb0202\":{\"built\":1},\"ueb1102\":{\"built\":1},\"ueb1105\":{\"kills\":1,\"built\":1},\"uea0107\":{\"kills\":2},\"ueb0201\":{\"built\":1},\"uel0111\":{\"lost\":5,\"built\":5},\"ueb3101\":{\"kills\":3,\"built\":2},\"ueb1202\":{\"built\":8},\"uel0105\":{\"lost\":5,\"kills\":35,\"built\":29},\"uea0102\":{\"lost\":1,\"kills\":3,\"built\":12},\"zeb9501\":{\"built\":4},\"ueb0102\":{\"built\":2},\"uea0103\":{\"lost\":2,\"kills\":6,\"built\":11},\"del0204\":{\"built\":4},\"ueb2101\":{\"kills\":8},\"uel0001\":{\"kills\":1,\"built\":1,\"lowest_health\":6127},\"uel0101\":{\"lost\":22,\"built\":25},\"ueb1106\":{\"built\":5},\"uel0103\":{\"lost\":60,\"kills\":61,\"built\":76},\"uel0205\":{\"built\":3}},\"type\":\"Human\",\"general\":{\"score\":40021,\"currentcap\":{\"count\":1000},\"lastReclaimedMass\":9073.68359375,\"kills\":{\"mass\":37599.23828125,\"count\":307,\"energy\":5149330},\"built\":{\"mass\":46948,\"count\":505,\"energy\":361915},\"lastReclaimedEnergy\":9884.3125,\"lost\":{\"mass\":17656.75,\"count\":312,\"energy\":131925.5},\"energy\":539523.9375,\"currentunits\":{\"count\":192},\"mass\":46600.25},\"faction\":1,\"resources\":{\"massin\":{\"total\":46600.25,\"rate\":6.8749995231628},\"energyover\":85497.265625,\"energyin\":{\"total\":539523.9375,\"rate\":98},\"energyout\":{\"total\":445011.09375,\"rate\":73.211479187012},\"massover\":506.07427978516,\"massout\":{\"total\":44979.5,\"rate\":7.8024988174438}},\"name\":\"Grothe\",\"units\":{\"air\":{\"lost\":19,\"kills\":13,\"built\":34},\"tech3\":{\"lost\":0,\"kills\":0,\"built\":0},\"cdr\":{\"lost\":0,\"kills\":1,\"built\":1},\"tech2\":{\"lost\":11,\"kills\":0,\"built\":52},\"tech1\":{\"lost\":301,\"kills\":306,\"built\":452},\"transportation\":{\"lost\":0,\"kills\":2,\"built\":2},\"land\":{\"lost\":289,\"kills\":256,\"built\":416},\"experimental\":{\"lost\":0,\"kills\":0,\"built\":0},\"structures\":{\"lost\":4,\"kills\":47,\"built\":74},\"engineer\":{\"lost\":5,\"kills\":41,\"built\":32},\"naval\":{\"lost\":0,\"kills\":0,\"built\":0},\"sacu\":{\"lost\":0,\"kills\":0,\"built\":0}}},{\"blueprints\":{\"ueb1102\":{\"built\":1},\"ueb1105\":{\"lost\":2,\"built\":6},\"uea0107\":{\"lost\":1,\"built\":2},\"ueb0101\":{\"lost\":9,\"built\":22},\"dea0202\":{\"kills\":2},\"uel0111\":{\"kills\":5},\"uel0104\":{\"lost\":4,\"kills\":13,\"built\":5},\"ueb3101\":{\"lost\":4,\"built\":5},\"ueb1202\":{\"built\":2},\"uel0001\":{\"lost\":1,\"built\":1,\"lowest_health\":0},\"uel0105\":{\"lost\":42,\"kills\":4,\"built\":72},\"ueb2104\":{\"lost\":3,\"built\":8},\"uel0106\":{\"kills\":1},\"ueb1101\":{\"lost\":7,\"kills\":2,\"built\":24},\"uel0202\":{\"kills\":4},\"ueb0102\":{\"built\":2},\"ueb2101\":{\"lost\":12,\"built\":13},\"ueb1103\":{\"lost\":14,\"kills\":1,\"built\":30},\"uea0102\":{\"lost\":2,\"kills\":5,\"built\":6},\"uea0103\":{\"kills\":10,\"built\":7},\"uel0101\":{\"kills\":22},\"uel0201\":{\"lost\":145,\"kills\":171,\"built\":150},\"uel0103\":{\"lost\":68,\"kills\":59,\"built\":82},\"uea0101\":{\"kills\":1}},\"type\":\"Human\",\"general\":{\"score\":27394,\"currentcap\":{\"count\":1000},\"lastReclaimedMass\":6482.9541015625,\"kills\":{\"mass\":17656.75,\"count\":312,\"energy\":131925.5},\"built\":{\"mass\":33536,\"count\":438,\"energy\":255205},\"lastReclaimedEnergy\":14605.770507813,\"lost\":{\"mass\":38639.859375,\"count\":324,\"energy\":5155457},\"energy\":389118.96875,\"currentunits\":{\"count\":141},\"mass\":36925.046875},\"faction\":1,\"resources\":{\"massin\":{\"total\":36925.046875,\"rate\":2.1475491523743},\"energyover\":30377.583984375,\"energyin\":{\"total\":389118.96875,\"rate\":44},\"energyout\":{\"total\":358752.625,\"rate\":43.999988555908},\"massover\":5.5986328125,\"massout\":{\"total\":36851.390625,\"rate\":5.5889530181885}},\"name\":\"bobbuild\",\"units\":{\"air\":{\"lost\":13,\"kills\":19,\"built\":17},\"tech3\":{\"lost\":0,\"kills\":0,\"built\":0},\"cdr\":{\"lost\":1,\"kills\":0,\"built\":1},\"tech2\":{\"lost\":0,\"kills\":11,\"built\":2},\"tech1\":{\"lost\":323,\"kills\":301,\"built\":435},\"transportation\":{\"lost\":2,\"kills\":0,\"built\":2},\"land\":{\"lost\":269,\"kills\":289,\"built\":332},\"experimental\":{\"lost\":0,\"kills\":0,\"built\":0},\"structures\":{\"lost\":51,\"kills\":4,\"built\":113},\"engineer\":{\"lost\":43,\"kills\":5,\"built\":73},\"naval\":{\"lost\":0,\"kills\":0,\"built\":0},\"sacu\":{\"lost\":0,\"kills\":0,\"built\":0}}},{\"blueprints\":[],\"type\":\"AI\",\"general\":{\"score\":0,\"currentcap\":{\"count\":1000},\"lastReclaimedMass\":0,\"kills\":{\"mass\":0,\"count\":0,\"energy\":0},\"built\":{\"mass\":0,\"count\":0,\"energy\":0},\"lastReclaimedEnergy\":0,\"lost\":{\"mass\":0,\"count\":0,\"energy\":0},\"energy\":0,\"currentunits\":{\"count\":0},\"mass\":0},\"faction\":5,\"resources\":{\"massin\":{\"total\":0,\"rate\":0},\"energyover\":0,\"energyin\":{\"total\":0,\"rate\":0},\"energyout\":{\"total\":0,\"rate\":0},\"massover\":0,\"massout\":{\"total\":0,\"rate\":0}},\"name\":\"civilian\",\"units\":{\"air\":{\"lost\":0,\"kills\":0,\"built\":0},\"tech3\":{\"lost\":0,\"kills\":0,\"built\":0},\"cdr\":{\"lost\":0,\"kills\":0,\"built\":0},\"tech2\":{\"lost\":0,\"kills\":0,\"built\":0},\"tech1\":{\"lost\":0,\"kills\":0,\"built\":0},\"transportation\":{\"lost\":0,\"kills\":0,\"built\":0},\"land\":{\"lost\":0,\"kills\":0,\"built\":0},\"experimental\":{\"lost\":0,\"kills\":0,\"built\":0},\"structures\":{\"lost\":0,\"kills\":0,\"built\":0},\"engineer\":{\"lost\":0,\"kills\":0,\"built\":0},\"naval\":{\"lost\":0,\"kills\":0,\"built\":0},\"sacu\":{\"lost\":0,\"kills\":0,\"built\":0}}},{\"blueprints\":{\"urc1301\":{\"built\":3},\"urc1101\":{\"built\":5},\"urc1201\":{\"built\":2},\"urc1401\":{\"built\":4},\"urc1501\":{\"built\":7},\"urb5101\":{\"built\":293}},\"type\":\"AI\",\"general\":{\"score\":0,\"currentcap\":{\"count\":1000},\"lastReclaimedMass\":0,\"kills\":{\"mass\":0,\"count\":0,\"energy\":0},\"built\":{\"mass\":0,\"count\":314,\"energy\":0},\"lastReclaimedEnergy\":0,\"lost\":{\"mass\":0,\"count\":0,\"energy\":0},\"energy\":0,\"currentunits\":{\"count\":0},\"mass\":0},\"faction\":5,\"resources\":{\"massin\":{\"total\":0,\"rate\":0},\"energyover\":0,\"energyin\":{\"total\":0,\"rate\":0},\"energyout\":{\"total\":0,\"rate\":0},\"massover\":0,\"massout\":{\"total\":0,\"rate\":0}},\"name\":\"civilian\",\"units\":{\"air\":{\"lost\":0,\"kills\":0,\"built\":0},\"tech3\":{\"lost\":0,\"kills\":0,\"built\":0},\"cdr\":{\"lost\":0,\"kills\":0,\"built\":0},\"tech2\":{\"lost\":0,\"kills\":0,\"built\":0},\"tech1\":{\"lost\":0,\"kills\":0,\"built\":293},\"transportation\":{\"lost\":0,\"kills\":0,\"built\":0},\"land\":{\"lost\":0,\"kills\":0,\"built\":21},\"experimental\":{\"lost\":0,\"kills\":0,\"built\":0},\"structures\":{\"lost\":0,\"kills\":0,\"built\":314},\"engineer\":{\"lost\":0,\"kills\":0,\"built\":0},\"naval\":{\"lost\":0,\"kills\":0,\"built\":0},\"sacu\":{\"lost\":0,\"kills\":0,\"built\":0}}}]}"], "command": "JsonStats", "target": "game"}
2016-12-05 08:10:54,180 INFO     fa.game_connection.GPGNetConnection GC >> : GameResult : [1, u'victory 10']
2016-12-05 08:10:54,180 INFO     fa.game_session.GameSession    Incoming GPGNet: GameResult [1, u'victory 10']
2016-12-05 08:10:54,180 INFO     fa.game_session.GameSession    Outgoing relay message GameResult [1, u'victory 10']

@GrotheFAF
Copy link
Author

well, the point is, I didn't die, I won that game, with an ACU close to healthy as can be. But the server result indicates a draw. (Replay shows both lost and the ladder-points fit a draw)
The other question is, why is there a 'Timeout/network error: The remote host closed the connection'?
Confusing:between reconnect and serverlogin, GameResults are exchanged 'score 1' ?
and then directly another 'timeout/network error' and more GameResults (which seem about right)
I don't know what is going on there with the connection.

@micheljung
Copy link
Member

I meant before he died.
No idea why you got disconnected, but AFAIK the server doesn't handle such disconnects very well; Fixed in #237

@GrotheFAF
Copy link
Author

apoligy accepted ;-)
ah, #237 would have captured that, but it's still open, so not yet in active server, right?
and the above is one of the rather rare cases. (1% or below for me)

@micheljung
Copy link
Member

Yes, at least in some cases; if both players disconnect, the game will be marked as "ended", but as long as at least one player is connected, #237 will restore the players "game state" once he reconnects. This is necessary in order for the player to report results, I think. #237 will be deployed with the next server update and requires client-side support. (FAForever/client#522)

@micheljung
Copy link
Member

micheljung commented Dec 16, 2016 •
edited

Game: 5537057
Blodir claims to have won.

mysql> select login, mean, after_mean, place, score, scoretime from game_player_stats join login on login.id = playerid where gameid = 5537057;
+-----------------+---------+------------+-------+-------+---------------------+
| login           | mean    | after_mean | place | score | scoretime           |
+-----------------+---------+------------+-------+-------+---------------------+
| Tokyto_         | 2155.69 |    2169.23 |     3 |    10 | 2016-12-15 22:29:27 |
| JaggedAppliance |  1920.7 |    1912.25 |     5 |    -1 | 2016-12-15 22:29:26 |
| Blodir          | 2333.08 |    2321.55 |     4 |     0 | 2016-12-15 22:29:27 |
| AchievedJaguar8 | 2107.64 |    2123.36 |     6 |    -1 | 2016-12-15 22:29:27 |
+-----------------+---------+------------+-------+-------+---------------------+

Scores reported by JaggedAppliance:

2016-12-15 23:27:58.156
Player(JaggedAppliance, 118147, (1920.7, 69.9235), (2102.74, 65.2438)) reported result for army 3: victory 10
2016-12-15 23:27:50.752
Player(JaggedAppliance, 118147, (1920.7, 69.9235), (2102.74, 65.2438)) reported result for army 4: defeat -10
2016-12-15 23:27:47.419
Player(JaggedAppliance, 118147, (1920.7, 69.9235), (2102.74, 65.2438)) reported result for army 3: score 1

Scores Reported by Tokyto_:

2016-12-15 23:27:57.634
Player(Tokyto_, 477, (2155.685015980395, 88.8861431906999), (1893.31, 61.0745)) reported result for army 3: victory 10
2016-12-15 23:27:50.251
Player(Tokyto_, 477, (2155.685015980395, 88.8861431906999), (1893.31, 61.0745)) reported result for army 4: defeat -10
2016-12-15 23:27:46.889
Player(Tokyto_, 477, (2155.685015980395, 88.8861431906999), (1893.31, 61.0745)) reported result for army 3: score 1

Scores reported by Blodir:

2016-12-15 23:27:57.667
Player(Blodir, 133636, (2333.08, 81.9026), (2305.16, 56.912)) reported result for army 3: victory 10
2016-12-15 23:27:50.261
Player(Blodir, 133636, (2333.08, 81.9026), (2305.16, 56.912)) reported result for army 4: defeat -10
2016-12-15 23:27:46.915
Player(Blodir, 133636, (2333.08, 81.9026), (2305.16, 56.912)) reported result for army 3: score 1

Scores reported by AchievedJaguar8:

2016-12-15 23:27:57.667
Player(Blodir, 133636, (2333.08, 81.9026), (2305.16, 56.912)) reported result for army 3: victory 10
2016-12-15 23:27:50.261
Player(Blodir, 133636, (2333.08, 81.9026), (2305.16, 56.912)) reported result for army 4: defeat -10
2016-12-15 23:27:46.915
Player(Blodir, 133636, (2333.08, 81.9026), (2305.16, 56.912)) reported result for army 3: score 1

Related error message:

2016-12-15 23:27:50.261
Player(Blodir, 133636, (2333.08, 81.9026), (2305.16, 56.912)) reported result for army 4: defeat -10
2016-12-15 23:27:50.252
IndexError: list index out of range
2016-12-15 23:27:50.252
survived = army_result[1] == 'victory'
2016-12-15 23:27:50.252
File "/code/server/stats/game_stats_service.py", line 56, in process_game_stats
2016-12-15 23:27:50.252
await self._game_stats_service.process_game_stats(player, self, self._army_stats)
2016-12-15 23:27:50.252
File "/code/server/games/game.py", line 279, in _process_army_stats_for_player
2016-12-15 23:27:50.252
Traceback (most recent call last):
2016-12-15 23:27:50.252
Army stats could not be processed from player Player(Blodir, 133636, (2333.08, 81.9026), (2305.16, 56.912)) in game Game(5537057,Blodir,maps/scmp_014.zip,4)
2016-12-15 23:27:50.251
Processing game stats for player: Blodir

Then there is also:

2016-12-15 23:27:57.634
Ignoring results for unknown army 2: victory 10 reported by: Player(Tokyto_, 477, (2155.685015980395, 88.8861431906999), (1893.31, 61.0745))
2016-12-15 23:27:57.631
Ignoring results for unknown army 2: victory 10 reported by: Player(Blodir, 133636, (2333.08, 81.9026), (2305.16, 56.912))
2016-12-15 23:27:57.627
Ignoring results for unknown army 2: victory 10 reported by: Player(AchievedJaguar8, 111077, (2107.64, 95.8507), (1312.71, 57.2211))

Also I found this:

server/server/games/game.py

Line 367 in 58a9135

# FIXME: Assertion about startspot == army

@Crotalus
Copy link
Member

Crotalus commented Dec 16, 2016 •
edited

Hmm, seems like the check
survived = army_result[1] == 'victory'
is invalid in the stats processing. game.get_army_result returns a list of results reported for an army. That method should probably be renamed to get_army_results() or just return the result which most player reported.

Here's an example how it's handled in _process_pending_army_stats:
https://github.com/FAForever/server/blob/develop/server/games/game.py#L268

Dynamic-typed languages ftw ;)

@GrotheFAF
Copy link
Author

is there maybe a copy paste error? -> Scores reported by AchievedJaguar8 are Blodir.
the last one listed from JaggedAppliance came in 36 minutes before all other reports -> wrong game? -> 5537029 (start:22:44+ duration 9:52) report 22:53 -> fits.

@Crotalus Crotalus mentioned this issue Dec 17, 2016
Closed
@micheljung
Copy link
Member

micheljung commented Dec 19, 2016 •
edited

@Crotalus I think this is a follow-up error. I looked at the code a few times already, and IMO army_result[1] should always be set at this point.

game.get_army_result returns the result of a single player, an array containing the score and victory/draw/defeat/mutual_draw so I don't see why it should be named plural?

And yes, @GrotheFAF that was an error, I removed it, thx.

@Crotalus
Copy link
Member

Crotalus commented Dec 19, 2016 •
edited

In the current code game.get_army_result(army_id) returns an array of tuples, i.e. all reported results for a player, so something like this for a specific army:

result = [ 
    (1, 'victory', 10),
    (2, 'victory', 10)
    ...
]

(army 1, 2 reported victory 10 points for that player)

and then stats processor check result[1] == 'victory' which will fail if only one player has reported result for an army-ID. That's what #257 fixes but this may not be the main issue, why army 2 was invalid is another question.

@micheljung
Copy link
Member

image

@micheljung micheljung self-assigned this Dec 28, 2016
@coveralls coveralls mentioned this issue Dec 28, 2016
Closed
@shalkya
Copy link
Member

shalkya commented Aug 22, 2017 •
edited

there is still issue with rating it seems
http://content.faforever.com/faf/vault/replay_vault/replay.php?id=6674050
ladder game between me and robogear that i won.
image
rating didn't change before and after game
image
my opponent doesn't show up in the bottom right box.
here game logs : https://gist.github.com/shalkya/4b0a3261938a9615f4eed19a3adeafe7

@Askaholic
Copy link
Collaborator

Old issue. Rating code has been rewritten

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@micheljung micheljung

Labels
in progress
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@Crotalus @micheljung @shalkya @Askaholic @GrotheFAF