Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign party commands #600

Open
Askaholic opened this issue Jun 3, 2020 · 1 comment
Open

Redesign party commands #600

Askaholic opened this issue Jun 3, 2020 · 1 comment
Milestone

Comments

@Askaholic
Copy link
Collaborator

It may be better to send party commands using a single command with many subcommands than our current implementation of having a separate command for every action.

We could go with a "polymorphic" approach:

{
    "command": "party",
    "action": "invite",
    "recipient_id": <player_id>
}

Or more of a "compositional" approach:

{
    "command": "party",
    "action": "invite",
    "data": {
        "recipient_id": <player_id>
    }
}

The compositional approach has a little more boilerplate built into the message, but it feels cleaner to me.

@Askaholic Askaholic added this to To do in Team Matchmaker via automation Jun 3, 2020
@BlackYps BlackYps added this to the v2.0 milestone Nov 5, 2021
@Sheikah45
Copy link
Member

I would vote for the polymorphic as all the other commands follow this format. And it would be weird to start mixing them up now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

3 participants