Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable cache busting for assets on deploy #496

Closed
fcaps opened this issue Nov 25, 2023 · 3 comments · Fixed by #497
Closed

Enable cache busting for assets on deploy #496

fcaps opened this issue Nov 25, 2023 · 3 comments · Fixed by #497
Assignees

Comments

@fcaps
Copy link
Collaborator

fcaps commented Nov 25, 2023

What happened:
a route got removed from production "js/app/members/newshub.json"
this route was called from a js file that got cached in the reverse-proxy.

to overcome this issue, assets should be loaded with a version qyery-parameter like "https://faforever.com/js/app/newshub.js?v=2"

@fcaps fcaps self-assigned this Nov 25, 2023
@fcaps
Copy link
Collaborator Author

fcaps commented Nov 26, 2023

after investigating a bit, it seams like grunt is not supported when it comes to cache busting.
there is a plugin but there is no pug plugin for it.
writing such a plugin would be a waste of time, since webpack is better maintained and there is even a pug plugin for cache busting , swithing to webpack is a good idea in general.

@JaviTrek
Copy link
Collaborator

@fcaps switching to webpack would be peak, grunt is just terrible all around.

Do you need help with that? It shouldn't be too hard

@fcaps
Copy link
Collaborator Author

fcaps commented Nov 26, 2023

@JaviTrek you could review the PR :)

open tasks if you like to do them:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants