Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aggregations triggered on user profile edit #1118

Closed
knirirr opened this issue Jul 6, 2021 · 2 comments
Closed

Aggregations triggered on user profile edit #1118

knirirr opened this issue Jul 6, 2021 · 2 comments
Labels
invalid This doesn't seem right low Priority for this task is low
Projects
Phase 1: Client prototyping
Milestone
Phase 8: Post-MVP

Comments

@knirirr
Copy link
Contributor

knirirr commented Jul 6, 2021 •
edited

A request is made for the Elasticsearch aggregations when loading /profiles/edit; this ought to be investigated as such a request is probably not necessary.
@knirirr knirirr added this to the Phase 7: Post-MVP milestone Jul 6, 2021
@knirirr knirirr added this to To do in Phase 1: Client prototyping via automation Jul 6, 2021
@knirirr
Copy link
Contributor Author

knirirr commented Jul 12, 2021

The source is this function, which seems to be called on each page load:

https://github.com/FAIRsharing/fairsharing.github.io/blob/master/src/main.js#L58-L67

@knirirr knirirr added low Priority for this task is low invalid This doesn't seem right labels Jul 12, 2021
@knirirr
Copy link
Contributor Author

knirirr commented Jul 13, 2021

Looks like it's (correctly) only triggered on page reload.

@knirirr knirirr closed this as completed Jul 13, 2021
Phase 1: Client prototyping automation moved this from To do to Closed tasks Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
invalid This doesn't seem right low Priority for this task is low
Projects
Phase 1: Client prototyping
  
Closed tasks
Milestone
Phase 8: Post-MVP
Development

No branches or pull requests
1 participant
@knirirr