Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create default column type for Rat #56

Open
FCO opened this issue Oct 11, 2018 · 2 comments
Open

Create default column type for Rat #56

FCO opened this issue Oct 11, 2018 · 2 comments
Labels
Default column type help wanted Extra attention is needed

Comments

@FCO
Copy link
Owner

FCO commented Oct 11, 2018

No description provided.

@MattOates
Copy link
Contributor

What's important to preserve with this type, numerical query operators or the precision and exact round trip reproduction of the Rat? Ideally this would be a composite derived type in the implementing DBMS with bigint numerator, bigint denominator, derived double precision numerator / denominator. It feels like if you explicitly defined a Rat type in your models over Num as a column you are likely keen for the precision to be stored exactly, which suggests using a text type and inflating/deflating.

@FCO
Copy link
Owner Author

FCO commented Dec 27, 2018

I was thinking about it and I think it would make difficult to search for columns of that type...
I needed a Rat and implemented as real, but it was only to solve a problem I was having. We should find a better way to do that.

@FCO FCO added help wanted Extra attention is needed and removed good first issue Good for newcomers labels Dec 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Default column type help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@FCO @MattOates