Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Include labels with atlases #22

Open
3 tasks
shnizzedy opened this issue Jun 12, 2024 · 0 comments
Open
3 tasks

✨ Include labels with atlases #22

shnizzedy opened this issue Jun 12, 2024 · 0 comments
Labels
enhancement New feature or request RBC https://github.com/PennLINC/RBC user-reported

Comments

@shnizzedy
Copy link
Member

shnizzedy commented Jun 12, 2024

Related problem

how do you know what regions the rows and columns represent in the connectivity tsvs?

They’re fully dependent on the atlases in the config. The Schaefer atlases come from https://github.com/ThomasYeoLab/CBIG/tree/v0.22.6-Edit_KRR_LITE_to_only_allow_for_corr_kernel/stable_projects/brain_parcellation/Schaefer2018_LocalGlobal/Parcellations/MNI, so I think they’d correspond to the labels in these CSVs: https://github.com/ThomasYeoLab/CBIG/tree/v0.22.6-Edit_KRR_LITE_to_only_allow_for_corr_kernel/stable_projects/brain_parcellation/Schaefer2018_LocalGlobal/Parcellations/MNI/Centroid_coordinates

[…]

I thought that the sidecars for the tsvs would list the row/column info for the tsvs, but it looks like they have the processing info for the bold scan

As far as I know, C-PAC never even loads the labels, it just does the correlating. I don’t know why we wouldn’t want to add that functionality though.
I think both CC atlases are from here, but I don’t see any labels for them

The people downloading RBC will definitely want to know what the regions in the connectivity matrices are

pennbbl.slack.com#rbc-collab/p1718043001881159 🧵

C-PAC, through v1.8.7 at least, just uses the integer keys for the labels in the connectivity matrices it generates.

Proposed feature

If we package labels with the atlases we package, we can include clear labels in these matrices like the examples in nilearn's documentation Compute and display a correlation matrix

Acceptance criteria

@shnizzedy shnizzedy added enhancement New feature or request user-reported RBC https://github.com/PennLINC/RBC labels Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request RBC https://github.com/PennLINC/RBC user-reported
Projects
Status: No status
Development

No branches or pull requests

1 participant