Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPL pipeline #68

Closed
pozz82 opened this issue Dec 23, 2015 · 1 comment
Closed

SPL pipeline #68

pozz82 opened this issue Dec 23, 2015 · 1 comment

Comments

@pozz82
Copy link

pozz82 commented Dec 23, 2015

Hello,
in SPL pipeline (openfda/openfda/spl/pipeline.py) I think that at lines 54 and 55 some parentheses are missing when calling self.flag_file().
Without parentheses a type error is reported because it's trying to pass as parameter of os.path a function handler instead of a string.

Moreover, the pipeline never run completely because the run method is called _run instead of simply run.

Regards
@dkrylovsb
Copy link
Collaborator

Everything is working properly at this point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pozz82 @dkrylovsb