Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Eigen from public interface #1381

Closed
garth-wells opened this issue Feb 4, 2021 · 0 comments · Fixed by #1410
Closed

Remove Eigen from public interface #1381

garth-wells opened this issue Feb 4, 2021 · 0 comments · Fixed by #1410
Labels
task A task to perform

Comments

@garth-wells
Copy link
Member

Having Eigen in the public interface can cause all sorts of problems around alignment. Eigen has some compiler-time settings that set the alignment, but these are not necessarily common across libraries that are linked. Aligned Eigen objects use different 'free' functions, and mixing alignments leads to segfaults.

Since two upstream compiled dependencies may use different alignments the only robust solution appears to be removing Eigen from the public interface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task A task to perform
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant