Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YouTube video can not full screen #8

Closed
sethliao opened this issue Mar 7, 2021 · 5 comments
Closed

YouTube video can not full screen #8

sethliao opened this issue Mar 7, 2021 · 5 comments

Comments

@sethliao
Copy link

sethliao commented Mar 7, 2021

No description provided.

@sethliao sethliao changed the title YouTube video 惨 YouTube video can not full screen Mar 7, 2021
@sethliao
Copy link
Author

sethliao commented Mar 7, 2021

It is the url can play in full screen
image

<iframe width="560" height="315" src="https://www.youtube.com/embed/6Hn1_UMTgPo" frameborder="0" allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture" allowfullscreen></iframe>

@sethliao
Copy link
Author

sethliao commented Mar 7, 2021

It is the url cannot be play and be fullscreen
image

<iframe src="https://www.youtube.com/embed/YWkCmR3KkLs" class="resize-vertical" style="height: 359px;"></iframe>

@kankaristo
Copy link
Collaborator

kankaristo commented Mar 7, 2021

allowfullscreen is deprecated, it should be given as allow="fullscreen" these days:
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/iframe#attributes

@kristofferR
Copy link

Yeah, allow="fullscreen" should be added into as a default into the snippet in 0.2.0.

@FHachez
Copy link
Owner

FHachez commented Jul 18, 2021

Thanks a lot for the details!
It has been added, it will be part of the next update of the plugin.

@FHachez FHachez closed this as completed Jul 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants