Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement to App Lock List (sorted, only apps etc.) (blacklist) #31

Closed
leonpoint opened this issue May 24, 2018 · 4 comments
Closed
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@leonpoint
Copy link
Collaborator

leonpoint commented May 24, 2018

We should improve the app lock list. It should

  • be sorted alphabetically
  • only include Apps, not services
  • inform the user that blocking 'Uniatron' will stop him from editing App locks or trading his steps if the app use time ran out. This will force the user to uninstall the app.
  • not show essential / emergency services and apps, such as the Telephone, Emergency Mode, etc.
  • (show blocked apps at the beginning of the list)

@leonpoint leonpoint added the enhancement New feature or request label May 24, 2018
@leonpoint leonpoint added this to the Final App milestone May 24, 2018
@FHellmann
Copy link
Owner

I have to agree with you in most of your points.

  • The third one will never happen, because our own app 'Uniatron' is not shown in the list. It is already filtered before.
  • I have no idea how to filter essential /emergency services/apps yet. Open for any ideas.

@leonpoint
Copy link
Collaborator Author

We might be able to filter out preinstalled apps (This will remove YouTube though, and Facebook on some devices)?
-> We could then manually add the most common social apps out there. It's not the cleanest workaround but might work.

@FHellmann
Copy link
Owner

Exactly... It is possible to query all the apps the user installed by himself. This excludes all system and pre-installed apps (e. g. YouTube).
But sure, we can include these apps with a configuration of our own.

@leonpoint leonpoint changed the title Improvement to App Lock List (sorted, only apps etc.) Improvement to App Lock List (sorted, only apps etc.) (blacklist) Jun 7, 2018
@leonpoint leonpoint self-assigned this Jun 13, 2018
@leonpoint
Copy link
Collaborator Author

@FHellmann issue almost fixed.

  1. The list should ideally refresh itself when the user checks / unchecks a box. I can't figure it out. Current state is 838f5eb.
  2. Getting a checkstyle violation in \uniatron\ui\setting\SettingViewModel.java

Found 'UR'-anomaly for variable 'name' (lines '63'-'95')

I can't resolve it.. 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants