Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FISCO BCOS v3.0.1验证不出address地址是EOA还是合约地址,即将address地址均验证为合约地址 #3118

Closed
hongfish opened this issue Nov 15, 2022 · 3 comments

Comments

@hongfish
Copy link

  • Address合约

https://github.com/OpenZeppelin/openzeppelin-contracts/blob/docs-v3.x/contracts/utils/Address.sol
https://github.com/OpenZeppelin/openzeppelin-contracts/blob/master/contracts/utils/Address.sol

  • VerifyAddr 合约

VerifyAddr.sol

// SPDX-License-Identifier: MIT
pragma solidity ^0.6.10;
import "./utils/Address.sol";

contract VerifyAddr {

    using Address for address;

    function verify(address addr) public view returns(bool) {
        return addr.isContract();
    }

}

VerifyAddr2.sol

// SPDX-License-Identifier: MIT
pragma solidity ^0.8.1;
import "./utils/Address.sol";

contract VerifyAddr2 {

    using Address for address;

    function verify(address addr) public view returns(bool) {
        return addr.isContract();
    }

}
  • Remix验证

0.6.10版验证

image

image

0.8.1版验证
image
image

  • FISCO BCOS v2.8.0验证

0.6.10版验证

使用合约VerifyAddr.sol部署后的合约地址进行验证,应该返回true,交易回执返回true
使用私钥用户的地址进行验证,应该返回false,交易回执返回false

结论:Fisco bcos v2.8.0验证address是EOA还是合约地址,验证正确。

  • FISCO BCOS V3.0.1验证

0.6.10版验证

使用合约VerifyAddr.sol部署后的合约地址进行验证,应该返回true,交易回执返回true
使用私钥用户的地址进行验证,应该返回false,交易回执返回true

结论:Fisco bcos v3.0.1验证address是EOA还是合约地址,验证错误。

0.8.1版验证

使用合约VerifyAddr2.sol部署后的合约地址进行验证,应该返回true,交易回执返回true
使用私钥用户的地址进行验证,应该返回false,交易回执返回true

结论:Fisco bcos v3.0.1验证address是EOA还是合约地址,验证错误。

@wheatli
Copy link
Contributor

wheatli commented Nov 22, 2022

谢谢反馈,3.1版本将修复

@JimmyShi22
Copy link
Member

3.1.0 已修复

@hongfish
Copy link
Author

用FISCO BCOS v3.1.0进行验证:
1、验证合约地址,返回空值
image

2、验证EOA,返回error
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants