Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to rounded forecast values? #9

Closed
hanzoh opened this issue Oct 6, 2020 · 3 comments
Closed

Switch to rounded forecast values? #9

hanzoh opened this issue Oct 6, 2020 · 3 comments

Comments

@hanzoh
Copy link

hanzoh commented Oct 6, 2020

This is just a feature request or more of an open discussion.

Wouldn't it look nicer in Lovelace, when the forecast temperatures are rounded?
The decimals propose a precision that cannot be true anyway.
For measured values and in the sensor entities, the decimals can remain so that there is a choice.

@FL550
Copy link
Owner

FL550 commented Oct 6, 2020

You are right, for the forecast values a round can be a good idea. But in my location the values are relatively precise.

The actual temperature is also only the forecasted value for this hour, as I haven't found a way yet to get measured values. And this "actual" forecast temperature corresponds rather good with the temperature I measure on my own.

@hanzoh
Copy link
Author

hanzoh commented Oct 6, 2020

I have just tried the following modification in connector.py, lines 99-100:

                        ATTR_FORECAST_TEMP: int(round(temp_max,0)),
                        ATTR_FORECAST_TEMP_LOW: int(round(temp_min,0)),

Looks like it does what both of us want, decimal "actual" value and rounded forecasts.

image

@FL550
Copy link
Owner

FL550 commented Oct 6, 2020

Thanks, I included this in v1.1.8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants