Upgrade phoenix

[vraravam]

Current version is "~> 1.3.3" - so, i'm unable to test this package with a phoenix 1.4 codebase. Also, (though not my specific usecase, but might be beneficial for someone else), it might be good to support umbrella app structure?

[Preen]

We are using it today within a umbrella structure! @mileandra can you provide @vraravam with info on how we are doing that. Also we should definitely start with development of supporting 1.4.

[vraravam]

As with code_demo for ex_admin - maybe it would be a good idea (for adoption this library) to provide an example/reference codebase?

[Preen]

yes definetaly. We'll provide you with that asap.

[vraravam]

If it works with both 1.3.3 and 1.4.0, then specifying the compatible versions with
~>1.3, <= 1.4.0 might solve my immediate problem?

[mileandra]

I created a hotfix for this that loosens up the dependency restrictions on phoenix and also allows for phoenix 1.4.
We will definitely add more examples and also an example repository.

@vraravam for the umbrella we just added the dependency in the admin application. Then in router.ex:

use Alkemist.Router
scope "/", Admin do
    pipe_through [:browser, :authenticate_user] #authenticate_user is a custom plug to ensure logged in user
    alkemist_resources("/my_resource", MyResourceController)
end

and in config.exs:

config :alkemist, Alkemist,
  repo: Db.Repo, #Repo is in different umbrella app
  router_helpers: Admin.Router.Helpers

[vraravam]

I'm trying out playing around with this package on this repo: git@gitlab.com:avijayr/phoenix14_starter.git
If I use the latest hotfix version, I still get errors with ecto which is at v3. (ex_machine as another example in the same repo can work with ~> 2.2 or ~> 3.0. Could you please relax that as well?

[mileandra]

Unfortunately ecto 3.0 is right now not supported by the dependency turbo_ecto at this point. So I fear for now you will probably have to work with override: true in your project until we were able to test this accordingly.

[JohnKacz]

Looks like turbo_ecto was just updated yesterday? zven21/turbo_ecto@bc21c9e