Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creation of EveryDueWorkdayMonth #19

Open
FMorschel opened this issue Feb 9, 2024 · 0 comments · May be fixed by #20
Open

Creation of EveryDueWorkdayMonth #19

FMorschel opened this issue Feb 9, 2024 · 0 comments · May be fixed by #20
Assignees
Labels
class_creation Issues related to new class creation enhancement New feature or request feature Asking for a new feature

Comments

@FMorschel
Copy link
Owner

Overview

The proposal is to introduce a new class, EveryDueWorkdayMonth, to enhance the capabilities of the package. This class is designed to generate a DateTime that is, for example, the fourth workday of the month, or the 7th, etc.

Related to: #17 and #18

Proposed Class

EveryDueWorkdayMonth
Purpose: This class is designed to generate a DateTime that is, for example, the fourth workday of the month, or the 7th, etc.
Parameters:

  • final int dueWorkday - The workday of the month this instance will generate for, inside the month.
    Usage Example:
const secondWorkday = EveryDueWorkdayMonth(2);
secondWorkday.startDate(DateTime(2024)); // would generate `DateTime(2024, 1, 2)`
secondWorkday.startDate(DateTime(2024, 5, 3)) // would generate `DateTime(2024, 6, 4)`

Benefits

Increased Functionality: The addition of EveryDueWorkdayMonth will enhance the package's functionality, catering to specific use cases.

Improved Code Organization: This new class contributes to better code organization by encapsulating the generation of specific workdays within a month.

Usability Enhancement: Users can benefit from EveryDueWorkdayMonth by being able to generate some DateTime that is a certain workday inside the month.

Additional Information

Dependencies: It would extend DateValidatorDueWorkdayMonth, mixin EveryMonth and implement EveryYear and EveryDateValidator.
Testing: It would be needed to test this class similarly to EveryDueDayMonth.


Your feedback on this proposal is highly encouraged. I will proceed with the implementation and submit a pull request.

@FMorschel FMorschel added enhancement New feature or request feature Asking for a new feature class_creation Issues related to new class creation labels Feb 9, 2024
@FMorschel FMorschel self-assigned this Feb 9, 2024
@FMorschel FMorschel linked a pull request Feb 9, 2024 that will close this issue
@FMorschel FMorschel linked a pull request Feb 9, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
class_creation Issues related to new class creation enhancement New feature or request feature Asking for a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant