Enable interacting with Widgets in Floating Overlay #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! I'm really sorry for taking so long to answer! Could you please give me more insight into what you meant by "refreshing the page"? Consider posting a screen recording or something like that. I would also really appreciate it if you took the time to create two more screen recordings to update this PR with the previous behaviour and the new behaviour. I've not personally used Flutter Web to publish anything, so I'm really unfamiliar with some of the things you may be aware of. It would greatly help me and this package in future features. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-using the reposition object enables interaction with the child widget as the overlay entry does not need to be rebuilt.
There are a few other issues relating to refreshing the page when using Flutter Web as state maintained in the FloatingOverlay. Adding a UniqueKey() solves the null issues for the overlay context that is lost but also means that the RouteObserver no longer works. :-S
Fixes: #5