Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused fueling after start fields #388

Closed
mck1117 opened this issue Mar 14, 2024 · 4 comments
Closed

Unused fueling after start fields #388

mck1117 opened this issue Mar 14, 2024 · 4 comments
Labels
💰 tech debt 💰 Not causing an active problem, but good to fix.

Comments

@mck1117
Copy link
Collaborator

mck1117 commented Mar 14, 2024

Looks like these don't do anything, should they?

int8_t[AFTERSTART_HOLD_CURVE_SIZE] afterstartCoolantBins;;"C", 1, 0, -40, 120, 0
uint8_t[AFTERSTART_HOLD_CURVE_SIZE] afterstartHoldTime;;"Seconds", 1, 0, 0, 100, 0
uint16_t[AFTERSTART_ENRICH_CURVE_SIZE] autoscale afterstartEnrich;;"ratio", 0.01, 0, 0, 10, 2
uint8_t[AFTERSTART_DECAY_CURVE_SIZE] afterstartDecayTime;;"Seconds", 1, 0, 0, 100, 0
@mck1117 mck1117 added the 💰 tech debt 💰 Not causing an active problem, but good to fix. label Mar 14, 2024
@nmschulte
Copy link
Contributor

nmschulte commented Mar 14, 2024

feature that was started, never completed, configs committed/started: rusefi/rusefi#1230

f08b154: introduces configs, doesn't use them
cbfdd37: references afterstartCoolantBins in tsOutputChannels.tuneCrc16
b27583a: improves tsOutputChannels.tuneCrc16 to not reference afterstartCoolantBins


seems like they can be removed for now, until the feature is re-introduced/completed

rusefillc pushed a commit to rusefi/rusefi that referenced this issue Mar 18, 2024
@rusefillc
Copy link
Contributor

@nmschulte @mck1117 thank you rusefi/rusefi@89c1b68

@mck1117
Copy link
Collaborator Author

mck1117 commented Mar 18, 2024

gone! adb5f6b

@mck1117 mck1117 closed this as completed Mar 18, 2024
@rusefillc
Copy link
Contributor

gone!

nope!

#define AFTERSTART_HOLD_CURVE_SIZE 8
#define AFTERSTART_DECAY_CURVE_SIZE 8
#define AFTERSTART_ENRICH_CURVE_SIZE 8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💰 tech debt 💰 Not causing an active problem, but good to fix.
Projects
None yet
Development

No branches or pull requests

3 participants