You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Current code compares output values against themselves, which doesn't solve anything.
Bounds checking both high and low, forward and back, would be useful.
Bounds should be defined with constants, not using magic numbers.
The text was updated successfully, but these errors were encountered:
the check against itself is actually a check for NaN, which would indicate a value outside or inside the reach of the arm. the x/y checks are to ensure we do not breach frame perimiter, and do need to me notated and moved to constants. will do
https://github.com/FRC5411/Lofty-2023/blob/89c03d89e93596035ac60450451b82608aee2649/src/main/java/frc/robot/subsystems/Arm.java#L171
Current code compares output values against themselves, which doesn't solve anything.
Bounds checking both high and low, forward and back, would be useful.
Bounds should be defined with constants, not using magic numbers.
The text was updated successfully, but these errors were encountered: