Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: different output strategies support #100

Merged
merged 2 commits into from Oct 26, 2020
Merged

Conversation

FRSgit
Copy link
Member

@FRSgit FRSgit commented Oct 26, 2020

add support for flatter & preserve-structure output strategies
move async & sync method to the separate files
export async & sync separately & bundled into index.js
extract util methods as a utils.js module
tweak & create new tests

BREAKING CHANGE: from this version on Node.js api ALWAYS returns an array of replace result array, where replace result array follows the pattern: [<replaced/new file path>, ]
BREAKING CHANGE: renamed regex option to needle

missing:

  • CLI update to handle output strategies correctly (and following tests)
  • README update

resolves #4

@FRSgit FRSgit added the enhancement New feature or request label Oct 26, 2020
@FRSgit FRSgit added this to the 3.0.0 milestone Oct 26, 2020
@FRSgit FRSgit self-assigned this Oct 26, 2020
@coveralls
Copy link

coveralls commented Oct 26, 2020

Pull Request Test Coverage Report for Build 368

  • 116 of 116 (100.0%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 346: 0.0%
Covered Lines: 128
Relevant Lines: 128

💛 - Coveralls

@FRSgit FRSgit force-pushed the output-strategies branch 8 times, most recently from e7306cd to e80b7d4 Compare October 26, 2020 22:18
add support for `flatter` & `preserve-structure` output strategies
move async & sync method to the separate files
export async & sync separately & bundled into index.js
extract util methods as a utils.js module
tweak & create new tests

BREAKING CHANGE: from this version on Node.js api ALWAYS returns an array of replace result array, where replace result array follows the pattern: [<replaced/new file path>, <replaced content>]
BREAKING CHANGE: renamed `regex` option to `needle`
BREAKING CHANGE: renamed `inputJoinString` option to `outputJoinString`
@FRSgit FRSgit merged commit d9cabac into master Oct 26, 2020
@FRSgit FRSgit deleted the output-strategies branch October 26, 2020 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(output): Allow multifile output
2 participants