Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Crash when crafting framed drawers with some blocks #1667

Closed
DarkBladeNemo opened this issue Nov 5, 2022 · 2 comments
Closed

[Bug]: Crash when crafting framed drawers with some blocks #1667

DarkBladeNemo opened this issue Nov 5, 2022 · 2 comments
Labels
1: Mod Issue A mod causing a problem. FTB StoneBlock 3 state: Fixed ✔️ An issue is solved and has been released.

Comments

@DarkBladeNemo
Copy link

Modpack

Stoneblock 3

Modpack version

1.0.2

Log Files

crash-2022-11-05_23.12.36-client.txt

Describe the bug

The game crashes when trying to craft Framed compacting drawer with Stripped dark oak and stripped spruce. Also crashes when using some chipped blocks.

Steps to reproduce

  1. Craft Framed compacting drawer
  2. Add stripped dark oak, stripped spruce and framed compacting drawer in crafting table.
  3. cry

Expected behaviour

Game crashes

Screenshots

No response

Additional information

No response

@Sunekaer
Copy link
Member

Sunekaer commented Nov 5, 2022

@tylerl
Copy link

tylerl commented Nov 25, 2022

This bug -- or a variant on this bug -- appears to be trivially reproducible with functionalstorage 1.0.7 (Stoneblock 3 1.4.1).

Successfully (unexpectedly) reproduced this crash with functionalstorage-1.18.2-1.0.7 as follows:

  • Craft a framed compacting drawer
  • Place in a crafting grid with stone block and gold block first (OK so far)
  • Accidentally replace the gold block in the grid with a cobblestone slab.
  • Profit!! (...er... crash)

Crafting grid on crash:

S B D
- - -
- - -

S: Cobblestone Slab
B: Stone Block
D: Framed Compacting Drawer
-: Empty

The most important details of the stack trace remain unchanged as reported above -- the model has a null side. Here's mine:

java.lang.NullPointerException: Cannot invoke "net.minecraft.core.Direction.m_122421_()" because "side" is null
	at com.buuz135.functionalstorage.client.loader.FramedModel$Baked.getMinMaxPosition(FramedModel.java:228) ~[functionalstorage-1.18.2-1.0.7.jar%23142!/:1.18.2-1.0.7] {re:classloading,pl:rei_plugin_compatibilities:B}
	at com.buuz135.functionalstorage.client.loader.FramedModel$Baked.getSpriteData(FramedModel.java:203) ~[functionalstorage-1.18.2-1.0.7.jar%23142!/:1.18.2-1.0.7] {re:classloading,pl:rei_plugin_compatibilities:B}
	at com.buuz135.functionalstorage.client.loader.FramedModel$Baked.getQuadsUsingShape(FramedModel.java:183) ~[functionalstorage-1.18.2-1.0.7.jar%23142!/:1.18.2-1.0.7] {re:classloading,pl:rei_plugin_compatibilities:B}
	at com.buuz135.functionalstorage.client.loader.FramedModel$ItemModel.getQuads(FramedModel.java:582) ~[functionalstorage-1.18.2-1.0.7.jar%23142!/:1.18.2-1.0.7] {re:classloading,pl:rei_plugin_compatibilities:B}
	at net.minecraftforge.client.model.data.IDynamicBakedModel.m_6840_(IDynamicBakedModel.java:27) ~[forge-1.18.2-40.1.84-universal.jar%23280!/:?] {re:classloading,pl:rei_plugin_compatibilities:B,re:mixin}

... etc.

@Sunekaer Sunekaer added state: Fixed in Dev 🛠️ An issue is fixed in-dev and pending for release. and removed state: Awaiting Mod Update Awaiting a mod update. labels Nov 28, 2022
@Sunekaer Sunekaer added state: Fixed ✔️ An issue is solved and has been released. and removed state: Fixed in Dev 🛠️ An issue is fixed in-dev and pending for release. labels Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1: Mod Issue A mod causing a problem. FTB StoneBlock 3 state: Fixed ✔️ An issue is solved and has been released.
Projects
None yet
Development

No branches or pull requests

3 participants