Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

identifierToDependency doesn't handle EAP releases properly #328

Closed
PawelLipski opened this issue Jun 5, 2020 · 0 comments · Fixed by #329
Closed

identifierToDependency doesn't handle EAP releases properly #328

PawelLipski opened this issue Jun 5, 2020 · 0 comments · Fixed by #329
Assignees
Labels
bug Something isn't working

Comments

@PawelLipski
Copy link

PawelLipski commented Jun 5, 2020

For instance, one can't add IC-202-EAP-SNAPSHOT to runPluginVerifier.ides (assuming https://www.jetbrains.com/intellij-repository/snapshots/ is added to repositories) since Gradle tries to resolve com.jetbrains.intellij.idea:ideaIC:202 rather than com.jetbrains.intellij.idea:ideaIC:202-EAP-SNAPSHOT.

Most likely replacing def (type, version) = identifier.split("-") with sth like def (type, version) = identifier.split("-", 1) should be enough (?)

That most likely should eventually belong in gradle-intellij-plugin, just as the rest of the plugin verifier logic... but still, the point remains :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants