GenericStyledArea.requestFollowCaret() does not show selection outside area on the right

[appsofteng]

When a selection of text in the area is on the right side outside of the visible area and GenericStyledArea.requestFollowCaret() is called, the flow scrolls only to the start of the selection, but the selection itself remains outside on the right.
This happens when the horizontal scrollbar is more far away from the beginning.

I made this change and it works now.

Only the relevant code shown. My comment [A]

private void followCaret() {

        // ...

        double graphicWidth = paragrafBox.getGraphicPrefWidth();
        Bounds region = extendLeft(caretBounds, graphicWidth);
        double scrollX = virtualFlow.getEstimatedScrollX();

        // Ordinarily when a caret ends a selection in the target paragraph and scrolling left is required to follow 
        // the caret then the selection won't be visible. So here we check for this scenario and adjust if needed.
        if ( ! isWrapText() && scrollX > 0.0 && getParagraphSelection( parIdx ).getLength() > 0 )
        {
           // [A] visibleLeftX has a rather large value when scrollX is big. This works fine for a selection outside the area
           // on the left but keeps a selection on the right outside the area. 
            double visibleLeftX = paragrafBox.getWidth() * scrollX / 100 - getWidth() + graphicWidth;

            CaretNode selectionStart = new CaretNode( "", this, getSelection().getStart() );
            paragrafBox.caretsProperty().add( selectionStart );
            Bounds startBounds = paragrafBox.getCaretBounds( selectionStart );
            paragrafBox.caretsProperty().remove( selectionStart );

            // [A] I use this changed condition and it works for both left and right.
            // startBounds.getMinX() - graphicWidth < scrollX
            if ( startBounds.getMinX() - graphicWidth < visibleLeftX ) {
                region = extendLeft( startBounds, graphicWidth );
            }
        }

    // ...

}

[Jugen]

So, just to confirm that the only change needed is for visibleLeftX to be scrollX to get the desired effect, like this ?

            if ( startBounds.getMinX() - graphicWidth < scrollX ) {
                region = extendLeft( startBounds, graphicWidth );
            }

[appsofteng]

Yes, I confirm.

[Jugen]

Okay will submit PR to fix ....