Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] tests depend on siibra-api #1260

Open
xgui3783 opened this issue Nov 11, 2022 · 0 comments
Open

[bug] tests depend on siibra-api #1260

xgui3783 opened this issue Nov 11, 2022 · 0 comments
Labels

Comments

@xgui3783
Copy link
Member

currently tests require siibra-api to be healthy. While this has some advantages (does not need test data to be hard coded), this also makes the tests significantly more flaky.

e.g.

  • if siibra-api is down, the tests will obviously fail
  • if siibra-api is polluted with wrong data, tests will fail
  • if siibra-api version mismatches, angular tests will fail with cyrptic messages such as "Injector already destroyed" (in the even version mismatches, viewer will display snack message of version mismatch. In a test, the angular app is destroyed before the snackbar message can be properly dismissed)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant