Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing information in Readme.md #2

Closed
proclamo-zz opened this issue Oct 15, 2011 · 6 comments
Closed

Missing information in Readme.md #2

proclamo-zz opened this issue Oct 15, 2011 · 6 comments

Comments

@proclamo-zz
Copy link

In autoload.php:

$loader->registerNamespaces(array(
...

'DoctrineExtensions' => DIR.'/../vendor/doctrine-extensions-taggable/lib',

));

and in app/config.yml:

fpn_tag:
model:
tag_class: FPN\TagBundle\Entity\Tag
tagging_class: FPN\TagBundle\Entity\Tagging

@leevigraham
Copy link

This also fixed my issue but raises another one (I think).

I don't think the autoloader should use 'DoctrineExtensions' as the key. I'm also using @l3pp4rd's doctrine extensions implemented in Symfony2 by @stof.

I'm still feeling my way around Symfony2 so I can't offer a pull request or clearly identify the issue. Happy to be told that I'm wrong but isn't there a chance of naming conflicts when using 'DoctrineExtensions'?

@stof
Copy link

stof commented Nov 14, 2011

There is a conflict as DoctrineExtensions is already used as namespace by @beberlei (who is Doctrine lead dev)

@l3pp4rd
Copy link

l3pp4rd commented Nov 14, 2011

Yes, try to think some vendor namespace of your own, it will conflict otherwise

@leevigraham
Copy link

@stof / @l3pp4rd Thanks for confirming my initial thoughts. Time to look deeper into DI so I can create a PR :D

@leevigraham
Copy link

I've created a separate issue for the potential autoloader conflict naming here: #3

@stof
Copy link

stof commented Nov 14, 2011

Well, the first step is not about DI. It is about changing the namespace of the related library to something else. And this should be let to the owner so that he choose the name he wants to use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants