Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package visibility index reforms #445

Open
liach opened this issue Mar 31, 2022 · 0 comments
Open

Package visibility index reforms #445

liach opened this issue Mar 31, 2022 · 0 comments

Comments

@liach
Copy link
Contributor

liach commented Mar 31, 2022

Since we now have access widener, for the package visibility index, instead of joining classes into disjoint unions, we should track package-access entry references and see if they are fulfilled by the mapping (either raise the referenced entry's access level or check if they are mapped into the same package).

In addition, we can consider if we should always run this visibility index with jar index or only run it manually, as now it's always run with the jar index but almost never used (only used from enigma cli, yarn mapping check)

In addition, we should probably enforce same-package rule for nests: if a nest member is not in the same runtime package as its host, it's automatically on its own (see jvms 5.4.4, access control).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant