Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Fabric API dependencies #55

Closed
kvverti opened this issue May 29, 2020 · 4 comments
Closed

Remove Fabric API dependencies #55

kvverti opened this issue May 29, 2020 · 4 comments

Comments

@kvverti
Copy link

kvverti commented May 29, 2020

Remove the modImplementation of the full fabric API, and remove "fabric": "*" from the example mod's fabric.mod.json.

Leaving the fabric API in the example mod means that many mods depend on the full Fabric API, even when they don't use all of API's modules.

This issue is part of a plan to improve depending on Fabric API.

@Pyrofab
Copy link

Pyrofab commented May 29, 2020

I think one possibility would be to add commented out dependencies on every existing API module. That way, enabling modules just takes a few keystrokes, and discoverability stays high.

@i509VCB
Copy link
Contributor

i509VCB commented May 29, 2020

Until a solution is written up and accepted, I would say no.

@eehunter
Copy link

@Pyrofab JSON doesn't allow comments.

@modmuss50
Copy link
Member

No, this repo is to help most people get started, and most people need the API. There is a comment that mentions its not required.

@modmuss50 modmuss50 closed this as not planned Won't fix, can't repro, duplicate, stale Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants