Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tinted glass shadow/AO issue #1708

Closed
LizIsTired opened this issue Sep 10, 2021 · 8 comments · Fixed by #2344
Closed

Tinted glass shadow/AO issue #1708

LizIsTired opened this issue Sep 10, 2021 · 8 comments · Fixed by #2344
Labels
bug Something isn't working indigo Pull requests and issues related to Indigo's implementation of the rendering api

Comments

@LizIsTired
Copy link

In at least the 0.4 Fabric API for 1.17.1, there appears to be issues with either shadows or ambient occlusion in specific situations using tinted glass.

Setup:
For my setup, I'm running Minecraft 1.17.1, Fabric Loader 11.6 and only 0.4 Fabric API with no resource packs.

This is an example of it working as expected with FAPI
2021-09-10_18 23 17
However, in this arrangement, there are clear lines where there shouldn't be, it should be smooth.
2021-09-10_18 24 08

@modmuss50
Copy link
Member

Are you using 0.40.1 or 0.40.0? If 0.40.1 can you try 0.40.0 and see if the resolves the issue?

@LizIsTired
Copy link
Author

This is 0.40.0+1.17, I can try with 0.40.1 and post some SS for comparison

@modmuss50
Copy link
Member

Ah, ok. The reason I ask is 0.40.1 had a rendering related change (#1701) and want to make sure that its not caused by that.

@LizIsTired
Copy link
Author

LizIsTired commented Sep 10, 2021

This is FAPI 0.40.1
2021-09-10_19 28 18
alt angle
2021-09-10_19 27 52
edit: reshot in daylight

@modmuss50 modmuss50 added bug Something isn't working indigo Pull requests and issues related to Indigo's implementation of the rendering api labels Sep 10, 2021
@haykam821
Copy link
Contributor

I couldn't reproduce this issue with Fabric API 0.40.1. What does it look like in vanilla? Could it be hardware-dependent?

  Vanilla Indigo
Square Vanilla square Indigo square
Staircase Vanilla staircase Indigo staircase

@LizIsTired
Copy link
Author

LizIsTired commented Sep 12, 2021

Sorry, I've been busy IRL.

Could it be hardware-dependent?

It might be possible that it's hardware dependant, but don't take my opinion, I have no idea how any of the Fabric API works lmao

Vanilla Indigo
Square 2021-09-12_23 45 13 2021-09-12_23 40 48
Staircase 2021-09-12_23 45 53 2021-09-12_23 46 46

I'll also leave a copy of my logs and a clear F3 screenshot as well as my driver versions
latest.log
2021-09-12_23 54 49
image

edit: included driver versions from Radeon Software

@FwuffyPetsOwO
Copy link

2021-09-12_16 10 00

As you can see, I have this issue as well. I am using an M1 Mac, and Fabric API 0.40.1.

@LizIsTired
Copy link
Author

2021-10-08_10 57 37
Issue persists in FAPI 0.40.6, any new developments or at least any luck in reproducing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working indigo Pull requests and issues related to Indigo's implementation of the rendering api
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants