Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hints at True Mojang names. #128

Closed
ryantheleach opened this issue Oct 16, 2016 · 1 comment
Closed

Hints at True Mojang names. #128

ryantheleach opened this issue Oct 16, 2016 · 1 comment

Comments

@ryantheleach
Copy link
Contributor

In AIGoalArrowAttack there is an exception that reveals some of the potential names for the real names of the class, Which brings the question,

Where possible, should we be attempting to use the real names that Mojang use? Avoiding their use? Or coming up with the best names that we can given the evidence?

e.g.

        if (!(aIDistantAttacker1 instanceof EntityLiving)) {
            throw new IllegalArgumentException("ArrowAttackGoal requires Mob implements RangedAttackMob");
        }

Implies that the class should really be called ArrowAttackGoal, IDistantAttacker called Mob, and EntityLiving called RangedAttackMob ?

This seems confusing though, as I would have expected that the instanceof check is backwards considering the current naming.

@asiekierka
Copy link
Contributor

From experience, I know that the Mojang names are sometimes left unupdated.

They're a hint, sure, but compatibility with Mojang's internal mappings was never a goal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants