-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extremely controversial: Block -> BlockType; Item -> ItemType; ItemStack -> Item #342
Comments
The main thing is that there's already a |
ItemStack tho |
Then that would require Item -> ItemStackType and that would just be hell. Plus, there's already official Mojang established names for Block and Item, but not BlockEntity and the like. |
I was going to suggest this at some point, actually. Exactly the same renames. So I'm all for it :D |
I'm all for this. The new name better communicates that the classes are flyweights, which is a common pitfall for new modders. |
sponge api does have many nice names, e.g. text instead of component |
Not completely opposed. "Type" is a loaded word, and that flyweight sense that we're trying to communicate might not come across. What about I think we should keep |
Or |
Nah, it's main job isn't to be a registry entry. |
i think |
tbh I am not a huge fan. I can understand where you are coming from, but we always had Block and all modders are used to them. Plus Block type would kind of imply that there is an actual Block too. |
"all modders are used to them" is not a good reason. There's a lot of names that were changed from the well known ones despite that in Yarn mappings, eg. BlockEntity |
I think it's a thoroughly shit idea but "modders are used to them" is the worst argument you could've pulled out because that does not matter |
With a vote ratio of 3:1 I will close this |
Is this an insane idea? Probably. But it would be consistent with BlockEntityType, ParticleType, EntityType, etc.
you should probably 馃憥 right now
The text was updated successfully, but these errors were encountered: