Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mixins causing incompatibility with DashLoader #73

Closed
snoandpetals opened this issue Dec 19, 2023 · 2 comments
Closed

Mixins causing incompatibility with DashLoader #73

snoandpetals opened this issue Dec 19, 2023 · 2 comments

Comments

@snoandpetals
Copy link

DashLoader currently crashes trying to initialize a Transformation because it passes in the standard 3 Vec3f's, when Porting Lib makes Minecraft expect 4. I narrowed it down to ItemTransformMixin, and I believe that's what's causing it because it introduces another non-nullable variable for initialization.

Cause: net.minecraft.client.render.model.json.Transformation.<init>(org.joml.Vector3f,org.joml.Vector3f,org.joml.Vector3f,org.joml.Vector3f)Suggestion: Check if the constructor holds all of the fields.

Object Stacktrace:
	in Transformation_<@DataNullablenull>
	at field thirdPersonLeftHand in DashModelTransformation_<@DataNullablenull>
	at field transformation in DashBasicBakedModel

extensions/src/main/java/io/github/fabricators_of_create/porting_lib/extensions/mixin/client/ItemTransformMixin.java
extensions/src/main/java/io/github/fabricators_of_create/porting_lib/extensions/extensions/ItemTransformExtensions.java

@TropheusJ
Copy link
Member

Marking the field as nullable would probably make it not crash, but dashloader would probably not deserialize extended transformations properly. I would need to look into how dashloader works to add actual compat.

@TropheusJ
Copy link
Member

dashloader is discontinued, this won't be fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants