Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Folder + file structur different to com_fabrik/layouts #12

Open
trob opened this issue Feb 6, 2016 · 3 comments
Open

Folder + file structur different to com_fabrik/layouts #12

trob opened this issue Feb 6, 2016 · 3 comments

Comments

@trob
Copy link
Contributor

trob commented Feb 6, 2016

As in our Skype session:

/listactions is missing
but the files (which should be located in /listaction)
fabrik-delete-button.php (is using trash icon, but deleting a record is final...)
fabrik-edit-button.php
fabrik-view-button.php
dropdown.php
are not needed (general icon replacement is done in fabrik_icon.php)

fabrik-element-fileupload-widget.php
fabrik-element-user-form.php
don't exist in com_fabrik/layouts
What should they override?

@pollen8
Copy link
Member

pollen8 commented Feb 9, 2016

was this a skype conversation with me? Sorry I can't remember it :(
If the files are not needed we shouldn't include them.
I'm not clear from your description if there is one that should be included?

@trob
Copy link
Contributor Author

trob commented Feb 9, 2016

No, Skype was with Hugh.
fabrik-delete-button.php is overriding the X with trash icon (but deleting a record is final, so is trash icon a good idea?).
If it should be used it must be moved to /listactions
If not it can be removed (like edit/view/dropdown)

@trob
Copy link
Contributor Author

trob commented Feb 9, 2016

fabrik-element-fileupload-widget.php

is in folder /elements in uikit
in "root" in bootstrap3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants