juserplugin can't handle usergroups correctly

[trob]

http://www.fabrikar.com/forums/index.php?threads/chkbox-drdown-plugs-dont-load-saved-values-into-details-form-after-editing-when-used-in-juser-plug.39090/
http://www.fabrikar.com/forums/index.php?threads/usergroups-element-and-juser-form-plugin.37957/

[trob]

I think I've found the issue with juser and the usergroups element not correctly populated with J!usergroups, it's just a typo:
if ($groupElementClass !== 'plgFabrik_ElementUsergroup') //must be __P__lgFabrik_ElementUsergroup
{
$gid = array_shift($gid);
}

But:
If not restricted by Fabrik list access settings (e.g. add/edit = public, which doesn't make sense but for testing purpose) everybody is allowed to create a new user and to assign any groups (but superuser), although guests and registered don't have create user access in Joomla user options.

Nobody (but superuser) is allowed to save a record with groups he doesn't belong to, even if he's an admin (who can do this in backend).
So:
juser-plugin should not save anything if

• the user isn't allowed to create a user
• the user isn't allowed to edit a user (but allowed to edit the fabrik list to modify additional elements)

[Makulia]

It'll also be good to have an option that defines which user groups are available for choice by list editor.

[Makulia]

I tried to extend this condition, and now it also works with checkbox plugin:
if ($groupElementClass !== 'PlgFabrik_ElementUsergroup' && $groupElementClass !== 'PlgFabrik_ElementCheckbox')
{
$gid = array_shift($gid);
}
It'll be good to merge this changes with juserplugin in repo or you have a better way of resolving this issue?

[pollen8]

I merged trob's commit (#1284) which I believe contains a fix for this issue

[Makulia]

Yep, fix is in the place, but only for the usergroup plugin. How about dropdown, picklist or checkbox plugins? I suggest you to add conditions for them to juserplugin. Thank you!