Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

list layout: headers don't wrap #1569

Closed
trob opened this issue Nov 14, 2015 · 7 comments
Closed

list layout: headers don't wrap #1569

trob opened this issue Nov 14, 2015 · 7 comments

Comments

@trob
Copy link

trob commented Nov 14, 2015

2feff0d
fabrik.css
+/** Prevent line breaks between sort icon and heading label in lists */
+
+.heading.fabrik_ordercell {

  • white-space: nowrap;

not good; this prevents any wrap in header labels and so expanding list width if you have some descriptive list headers

BTW: fabrik_ordercell is added even if the element is not set to "enable ordering"

@Sophist-UK
Copy link

IMO the correct way of prevent a line break at a specific point between sort icon and heading label is to use a non-breaking space  .

I appreciate that this does not make it easy (or possible) to override using CSS, but that is nevertheless the correct way to stop a line break at a specific point.

@trob
Copy link
Author

trob commented Nov 14, 2015

Not so easy because it's done with
<span class="some-icon"></span>Header text
eek, markdowns

@Sophist-UK
Copy link

<span class="some-icon"></span>&nbsp;Header text or
<span class="some-icon">&nbsp;</span>Header text

Simples.

@Sophist-UK
Copy link

Hmmm... on reflection I may have been talking b****cks.

I am not sure whether you get a line-breaking point between a span and text if there is no space between them. Is there a space inserted by Fabrik?

@trob
Copy link
Author

trob commented Jan 7, 2016

3.4.1:
fabrik_ordercell is still added to ALL headers, no matter if the element's "Enable odering" is set or not
and
.heading.fabrik_ordercell, .fabrikTag {
white-space: nowrap;
}
is preventing long headers from wrapping

A possible solution: instead of
<i class="icon-menu-2 " data-isicon="true"></i>Labeltext aa bb cc
do
<i class="icon-menu-2 " data-isicon="true" style="font-style:inherit"> abeltext aa bb cc</i>

or at least only set nowrap on ordered columns with
.heading.fabrik_ordercell a, .fabrikTag {
white-space: nowrap;
}

@pollen8
Copy link
Member

pollen8 commented Feb 3, 2016

personally I think this is a matter of choice, not a bug. I've had people argue the other way round. That wrapping the titles looks odd as well.
Ultimately I would suggest that its managed in the template css.

@pollen8 pollen8 closed this as completed Feb 3, 2016
trob referenced this issue Feb 11, 2016
…stop the title dropping below the order icon in some templates.
@trob
Copy link
Author

trob commented Feb 11, 2016

Seams to be fixed 85fb3b1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants