Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 7 migration issues #1954

Open
yuriyua opened this issue Feb 3, 2018 · 5 comments
Open

PHP 7 migration issues #1954

yuriyua opened this issue Feb 3, 2018 · 5 comments

Comments

@yuriyua
Copy link

yuriyua commented Feb 3, 2018

1. Variable Interpolation:

#### /var/www/html/administrator/components/com_fabrik/models/fields/collation.php
 * Line 47: `$defaultToTableValue = (bool) $this->element->attributes()->$defaultToTableValue[0];`

Error log:

Notice: Array to string conversion in /var/www/html/administrator/components/com_fabrik/models/fields/collation.php on line 47
Notice: Undefined property: stdClass::$Array in /var/www/html/administrator/components/com_fabrik/models/fields/collation.php on line 47

2. Deprecated Functions: mysql_fetch_array, mysql_data_seek

#### /var/www/html/plugins/fabrik_visualization/fusion_gantt_chart/libs/FCclass/FusionCharts_Gen.php
 * Line 331: ` while($row = mysql_fetch_array($query_result)) {`
 * Line 504: ` while($row = mysql_fetch_array($query_result)) {`
 * Line 522: ` mysql_data_seek($query_result,0);`
 * Line 523: ` while($row = mysql_fetch_array($query_result)) {`
 * Line 543: ` while($row = mysql_fetch_array($query_result)) {`
 * Line 606: ` while($row = mysql_fetch_array($query_result)) {`

#### /var/www/html/plugins/fabrik_visualization/fusionchart/libs/FCclass/FusionCharts_Gen.php
 * Line 331: ` while($row = mysql_fetch_array($query_result)) {`
 * Line 504: ` while($row = mysql_fetch_array($query_result)) {`
 * Line 522: ` mysql_data_seek($query_result,0);`
 * Line 523: ` while($row = mysql_fetch_array($query_result)) {`
 * Line 543: ` while($row = mysql_fetch_array($query_result)) {`
 * Line 606: ` while($row = mysql_fetch_array($query_result)) {`

Are these functions used anywhere?

@Sophist-UK
Copy link

I am using Fabrik on Php 7 without getting these.

What version of Fabrik are you on?

@yuriyua
Copy link
Author

yuriyua commented Feb 3, 2018

I am on Fabrik 3.8. I have no issues but we have deprecated code on the master
https://github.com/Fabrik/fabrik/search?utf8=%E2%9C%93&q=mysql_fetch_array&type=
...

@Sophist-UK
Copy link

Those are in deprecated plugins.

@Sophist-UK
Copy link

@yuriyua Please submit a PR to fix the Variable Interpolation issue in the collation form field type (used in List.xml).

@yuriyua
Copy link
Author

yuriyua commented Feb 3, 2018

I think this is the simplest fix #1955

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants