Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ShulkerBoxTooltip #2

Closed
2 of 5 tasks
Madis0 opened this issue Feb 17, 2021 · 4 comments
Closed
2 of 5 tasks

ShulkerBoxTooltip #2

Madis0 opened this issue Feb 17, 2021 · 4 comments
Labels
mod New Fabric mod to include rejected Mods and changes that will not be added

Comments

@Madis0
Copy link
Member

Madis0 commented Feb 17, 2021

Mod name
ShulkerBoxTooltip

Curseforge link
https://www.curseforge.com/minecraft/mc-mods/shulkerboxtooltip

Modrinth link
N/A

Other link
https://github.com/MisterPeModder/ShulkerBoxTooltip

What it does
Adds a visual tooltip for shulker boxes that show their contents.

Why should it be in the modpack
1.18 bundle parity, unless it gets implemented in vanilla (please vote)

Why shouldn't it be in the modpack
Slightly less vanilla behaviour, MisterPeModder/ShulkerBoxTooltip#43

Categories
Select any that match:

  • Performance optimization
  • Graphics optimization
  • New feature
  • Optifine parity
  • Fixes a bug/dependency

Additional details
Edit: bundles have been postponed, so I'll postpone this as well
Edit 2: bundles postponed again to 1.19
Edit 3: postponed again because they didn't figure out how to hover with touchscreens

@Madis0 Madis0 added the mod New Fabric mod to include label Feb 17, 2021
@Madis0 Madis0 added this to the 1.17 milestone Feb 17, 2021
@Madis0 Madis0 modified the milestones: MC 1.17, MC 1.18 May 12, 2021
@Madis0 Madis0 modified the milestones: MC 1.18, MC 1.19 Oct 17, 2021
@triphora
Copy link
Contributor

triphora commented Nov 5, 2021

Would be obsoleted by #66. FWIW, Inspecio is most likely going to have better general compatibility than SBT. On one of my own mods, it contains a custom screen handler to add some extra features to an existing vanilla screen. SBT was unable to detect shulkers within this container, but Inspecio was able to do it flawlessly. I don't know how many mods add a custom screen handler, especially not any within this modpack, but it's still worth considering.

@Madis0 Madis0 added the on hold Mods that are waiting for something before inclusion label Dec 13, 2021
@nsde
Copy link
Contributor

nsde commented Apr 12, 2022

Any updates on whether this mod should be added or Inspecio or neither?

@Madis0
Copy link
Member Author

Madis0 commented Apr 12, 2022

This basically waits on vanilla to see when and how bundles will be added to survival and in that case, will they change the shulker box tooltips as well.

Ideally the mod would only be added to 1.18 as a parity fallback and 1.19 will have it as part of vanilla. But for that to happen, please vote on the idea linked in the OP 😉

@Madis0 Madis0 removed this from the MC 1.19 milestone Apr 14, 2022
@Madis0 Madis0 mentioned this issue May 25, 2022
@Madis0 Madis0 added this to the Bundle update milestone Jul 7, 2022
@Madis0 Madis0 removed this from the Bundle update milestone Sep 14, 2023
@Madis0
Copy link
Member Author

Madis0 commented Sep 14, 2023

Even if bundles were implemented with the tooltips and shulker boxes didn't get them, this could be seen as cheaty and it defies vanilla expectations, possibly also someone's workflow who were used to reading text in tooltips. Therefore - rejected.

@Madis0 Madis0 closed this as not planned Won't fix, can't repro, duplicate, stale Sep 14, 2023
@Madis0 Madis0 added rejected Mods and changes that will not be added and removed on hold Mods that are waiting for something before inclusion labels Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mod New Fabric mod to include rejected Mods and changes that will not be added
Projects
None yet
Development

No branches or pull requests

3 participants