Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MidnightControls #330

Closed
RaptaG opened this issue May 14, 2022 · 17 comments
Closed

MidnightControls #330

RaptaG opened this issue May 14, 2022 · 17 comments
Labels
mod New Fabric mod to include
Projects

Comments

@RaptaG
Copy link
Contributor

RaptaG commented May 14, 2022

Mod name

MidnightControls

Curseforge link

https://www.curseforge.com/minecraft/mc-mods/midnightcontrols

Other links

Modrinth: https://modrinth.com/mod/midnightcontrols

GitHub: https://github.com/TeamMidnightDust/MidnightControls

What it does

Provides gamepad support!

Why should it be in the modpack

It offers MCBE parity, many people when moving from MCBE to Java miss the ability to use a gamepad and using methods with eg. Steam are very complicated.

Why shouldn't it be in the modpack

It requires the user to add by themselves the gamepad mappings, using an external app, and some of its extra features can be considered as cheats, so I made an issue for that.
The settings may be a little confusing.
Also, usually, people don't use a controller to play the Java Edition of the game.

Categories

New feature, Works like Bedrock Edition

Additional details

It's a fork of LamdaControls, which is no longer maintained. Also, it's no longer in beta.

TeamMidnightDust/MidnightControls#13

It should not be considered as a cheat mod (why)

@RaptaG RaptaG added the mod New Fabric mod to include label May 14, 2022
@DioEgizio
Copy link

It requires the user to add by themselves the gamepad mappings, using an external app, and the settings may be a little confusing.

It can actually download mappings automatically

@DioEgizio
Copy link

@Madis0 Madis0 added the feedback/testers wanted Issues that could use more feedback from the users label May 14, 2022
@Madis0

This comment was marked as outdated.

@Kichura
Copy link
Member

Kichura commented May 15, 2022

I personally care about this because it opens up the accessibility to other people rather than being limited to keyboard & mice - and i feel like without this; wouldn't be as fun to play when game controller fans need such mods.

@DioEgizio
Copy link

DioEgizio commented May 15, 2022

I care about this too because it's nice, it's also very nice for Steam Deck users (even though I don't have a steam deck)

@Madis0
Copy link
Member

Madis0 commented May 15, 2022

Okay, let me rephrase this: I want to hear from people who actively use this (or an equivalent mod, even if on Forge or whatever), not those who just think it is a good idea or who maybe tried this once.

@Imzxhir
Copy link

Imzxhir commented May 15, 2022

I've use both MidnightControls and Controllable (Forge). In my opinion, I think it's a good mod to add because it opens the modpack up to a variety of users on different platforms like the steam deck for instance. It might need some configurartion with the 'General Options' and 'Controller Options' tab but after that it's fine and good to use.

@Jamelos
Copy link

Jamelos commented Jun 3, 2022

I've use both MidnightControls and Controllable (Forge). In my opinion, I think it's a good mod to add because it opens the modpack up to a variety of users on different platforms like the steam deck for instance. It might need some configurartion with the 'General Options' and 'Controller Options' tab but after that it's fine and good to use.

Exactly me.

@B055-Man
Copy link

B055-Man commented Jun 4, 2022

I used lambda controls while it was supported and now use midnight controls instead. Love using it and often just lie down with my laptop and play with my dualshock 4.

@RaptaG
Copy link
Contributor Author

RaptaG commented Jun 4, 2022

Allow me to add a report too, I've been using MidnightControls for a while now and it is amazing!

@Madis0
Copy link
Member

Madis0 commented Jun 15, 2022

Fine, I believe you that there is a demand for this.

Now, the question for those who use it - what do you think would be sensible defaults for this mod in FO to prevent cheating and to ease the initial setup? What setup is needed to get this working in the first place?

Note that I have not tried this mod yet and I do not have a controller anyway.

@Madis0 Madis0 added this to the MC 1.19 milestone Jun 15, 2022
@Madis0 Madis0 added this to To do in 1.19.2 via automation Jun 15, 2022
@Jamelos
Copy link

Jamelos commented Jun 15, 2022

Fine, I believe you that there is a demand for this.

Now, the question for those who use it - what do you think would be sensible defaults for this mod in FO to prevent cheating and to ease the initial setup? What setup is needed to get this working in the first place?

Note that I have not tried this mod yet and I do not have a controller anyway.

The mod already comes in a way thats not cheating and is equal to the console. If you want, you can enable the cheat features yourself. It functions very simply, put controller in, it detects it and enters Controller Mode. Click the keyboard or disconnect the controller, and it will switch to Keyboard mode. That simple. The mod doesn't affect performance neither show a big not vanilla like screen. Thats it. Just put the mod and bam. No more things, its already ready.

@Madis0
Copy link
Member

Madis0 commented Jun 24, 2022

Despite TeamMidnightDust/MidnightControls#21 (comment), the cheat options are still currently vaguely worded in-game as of 1.1.0. The dev said:

I'm going to completely remove these features in the next update, as they don't even work correctly atm

so FO will wait for that before inclusion.

@Madis0 Madis0 added the on hold Mods that are waiting for something before inclusion label Jun 24, 2022
@RaptaG
Copy link
Contributor Author

RaptaG commented Jun 25, 2022

The new version is out, with bug fixes, modded controller support, auto-adapting controller icons and MidnightControlsExtras which has the “cheat” features.

@Madis0 Madis0 moved this from To do to In progress in 1.19.2 Jun 26, 2022
@Madis0
Copy link
Member

Madis0 commented Jun 26, 2022

I tried adding it to FO 4.0.0-beta.5, but it made mining blocks impossible with the left mouse key. Cannot reproduce with a clean profile (of only that mod), so it must be something in FO that is conflicting... 🤔

(I didn't report it to the mod dev as they have enough unfixed bugs atm, we should figure the root cause out first.)

@RaptaG
Copy link
Contributor Author

RaptaG commented Jun 26, 2022

(I didn't report it to the mod dev as they have enough unfixed bugs atm, we should figure the root cause out first.)

Somebody did though 🤔:
TeamMidnightDust/MidnightControls#45

EDIT: Fixed in the latest version of the mod.

@Madis0 Madis0 removed the on hold Mods that are waiting for something before inclusion label Jul 2, 2022
@Madis0 Madis0 removed the feedback/testers wanted Issues that could use more feedback from the users label Jul 14, 2022
@Madis0 Madis0 moved this from In progress to Done in 1.19.2 Jul 14, 2022
@Madis0
Copy link
Member

Madis0 commented Jul 14, 2022

Added in 3.12.0 and 4.0.0-beta.6.

@Madis0 Madis0 closed this as completed Jul 14, 2022
@Madis0 Madis0 mentioned this issue Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mod New Fabric mod to include
Projects
No open projects
Development

No branches or pull requests

7 participants