Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ServerPingerFixer #801

Open
leumasme opened this issue Jan 29, 2024 · 2 comments
Open

ServerPingerFixer #801

leumasme opened this issue Jan 29, 2024 · 2 comments
Labels
mod New Fabric mod to include

Comments

@leumasme
Copy link

leumasme commented Jan 29, 2024

CurseForge link

- (unknown)

CurseForge Mod Distribution

Unknown

Modrinth link

https://modrinth.com/mod/serverpingerfixer

Source/other link

https://github.com/JustAlittleWolf/ServerPingerFixer

Mod file size

6.98 KB

License

(any other license)

What it does

Improve multiplayer menu server pinging by increasing the max pinging threads and clearning the pinging threadpool when refresh is clicked again.
Slightly accelerates pinging + fixes the ages-old vanilla bug of all server pings failing if you spam-click refresh (which also still exists in FO)

Why should it be in the modpack

  • small size
  • simple fix to a simple issue that shouldn't exist

Why shouldn't it be in the modpack

  • not on curseforge
  • the issue that it solves is quite minor
  • some servers block/rate-limit pings when spamming refresh anyway, so they still time out

Additional details

No response

@leumasme leumasme added the mod New Fabric mod to include label Jan 29, 2024
@Madis0
Copy link
Member

Madis0 commented Jan 29, 2024

Bug or not, if this isn't in vanilla, then servers may not expect it and cause negative effects, just like you said

some servers block/rate-limit pings when spamming refresh anyway, so they still time out

plus not marked as 1.20.4-compatible

@makindotcc
Copy link

makindotcc commented Jan 29, 2024

Bug or not, if this isn't in vanilla, then servers may not expect it and cause negative effects, just like you said

Negative effects:

  • same as without mod (missing server motd)

You can refresh spam server in vanilla Minecraft if servers in your serverlist are responding quickly enough. It is hard to take down server by DDoSing it with server motd packet request, so ~10 refreshes per second will not affect server performance in any way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mod New Fabric mod to include
Projects
None yet
Development

No branches or pull requests

3 participants