Abnormally high delta on single reflector #82
Replies: 5 comments 55 replies
-
|
Ok, I have some ideas here. First off, because ICMP timestamps are "milliseconds since midnight UTC" it's inevitable we'll have to deal with rollover issues... This is annoying but something we haven't tackled yet so it's not surprising we have a problem. Of course, if only one rolls over at a time, the voting by taking the 3rd of 5 should fix it... but if 3 roll over we'll have persistent ridiculous delays that take a while to decay. Several thoughts:
|
Beta Was this translation helpful? Give feedback.
-
|
https://www.reddit.com/r/lua/comments/zzkwb/luajit_now_supports_goto_using_the_lua_52_syntax/ looks like it |
Beta Was this translation helpful? Give feedback.
-
|
lua 5.1.5 is installed on my x86 router |
Beta Was this translation helpful? Give feedback.
-
|
aw damn. |
Beta Was this translation helpful? Give feedback.
-
|
I'll do it with an if statement rather than a goto, but it'll be just deeper indented code... tomorrow! I'm going to go read my book. if someone wants to figure out how to fix it in the mean time go for it. nah, just kidding, it was easy to just wrap all that stuff in the "else" clause... etc lots of indentation but in the end easy to write... fixed. |
Beta Was this translation helpful? Give feedback.
-
|
I've been digging deeper. It's a mess. The maintainer of luajit kind of stepped back 7 years ago, so luajit development has fragmented, though I have seen references that the 'old' maintainer is actually still somewhat active. The last release by the maintainer was https://www.freelists.org/post/luajit/LuaJIT210beta3 in Aug 2015. |
Beta Was this translation helpful? Give feedback.
-
|
Ok, I pushed a proposed scaffolding for the error handling to this branch... it's just got comments where we'd need to trigger reselection, and it's got a spot where it'd like to "goto" a label and skip over what we'd normally do if we had good data... but I don't know if we can rely on goto since it's 5.2 take a look and see what you think, we can revert or modify as needed |
Beta Was this translation helpful? Give feedback.
-
|
So far it's still up and running for me. @dlakelan I will check back in on it a little later this evening and pop some stats up here to make sure it doesn't look like we see any regressions. |
Beta Was this translation helpful? Give feedback.
-
Ah shoot. I thought that was something format was capable of handling. Thanks for checking that! If you know of a more elegant and proper way to do that, please do so. Otherwise I will poke at it more this evening 😀 |
Beta Was this translation helpful? Give feedback.
-
|
Elegant? No. I would probably just initialize to -1 or something that's obvious is a default value. But that might throw Julia of and mess up our plots |
Beta Was this translation helpful? Give feedback.
-
This might solve the scoping issue but probably we'd still need sanity checks etc even with a go-to. Maybe we should just put a rate setter and minimal log in the first/emergency branch of the if and leave the more substantial logging and rate setting inside the else branch? |
Beta Was this translation helpful? Give feedback.
-
|
Agreed. It'd just be helpful to more easily be able to exit early like a goto would allow. I'm starting to feel the consequences of not sleeping enough last night, because oops looked at this stuff for too long :D |
Beta Was this translation helpful? Give feedback.
-
|
Ok back from my thing, @Fail-Safe does the current version run for you without problems in the "normal" cases at least (we will have to come up with a way to test midnight rollovers separately). |
Beta Was this translation helpful? Give feedback.
-
|
Here's what it's looking like: |
Beta Was this translation helpful? Give feedback.
-
|
@dlakelan I'd say it's looking and feeling normal from my standpoint. I didn't see any major spikes when it rolled over to midnight GMT which would have been 7pm EST for me |
Beta Was this translation helpful? Give feedback.
-
|
Yay! I guess let's merge this to develop/main under assumption it's working ok, but if we need to fix further bugs with this issue let's keep this branch and do those fixes here? |
Beta Was this translation helpful? Give feedback.
-
|
Yeah, sounds good 👍 |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
@dlakelan FYI, seeing this (see 'Reselect signaled') under "normal" usage now: |
Beta Was this translation helpful? Give feedback.
-
at all, or you mean triggered by "issues"? because for the first while we should be reselecting every 30 seconds during the "soft start" are those happening? |
Beta Was this translation helpful? Give feedback.
-
|
There's only been one thus far and it was at ~24mins after service restart: root@OpenWrt:~/sqm-autorate# cat /tmp/sqm-autorate.log | grep Reselect
[INFO - 20220111T17:08:35]: Reselect signaled: #up_del = 4 | #down_del = 4 |
Beta Was this translation helpful? Give feedback.
-
|
Nice, so that's when we trigger it due to getting less than 5 responses. good! but it's still doing reselection on a clock in the "soft start" mode right? because we're providing a timeout on the Linda and it should be reselecting every 30 seconds during start up (but it won't print that message) |
Beta Was this translation helpful? Give feedback.
-
|
Correct, it's still doing the soft selection |
Beta Was this translation helpful? Give feedback.
-
|
@dlakelan Since 10:15pm EST yesterday until now, there have only been a handful of reselect events: root@OpenWrt:~# cat /tmp/sqm-autorate.log | grep Reselect
[INFO - 20220112T00:37:45]: Reselect signaled: #up_del = 4 | #down_del = 4
[INFO - 20220112T00:37:46]: Reselect signaled: #up_del = 4 | #down_del = 4
[INFO - 20220112T00:37:46]: Reselect signaled: #up_del = 4 | #down_del = 4
[INFO - 20220112T02:13:08]: Reselect signaled: #up_del = 4 | #down_del = 4
[INFO - 20220112T04:51:37]: Reselect signaled: #up_del = 4 | #down_del = 4
|
Beta Was this translation helpful? Give feedback.
-
Per @Lochnair:
Beta Was this translation helpful? Give feedback.
All reactions