Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential RBAC Support? #86

Closed
robotica72 opened this issue Oct 23, 2019 · 5 comments
Closed

Potential RBAC Support? #86

robotica72 opened this issue Oct 23, 2019 · 5 comments
Labels
enhancement Adding additional functionality or improvements help wanted Extra attention is needed stale Marked as stale by stalebot

Comments

@robotica72
Copy link

First, great project - I have been doing something similar at work as we enforce requests and limits for all deployments, but many developers have no idea what values to use. In our case we have a dev cluster that doesnt require the request and limits in the deployment and they look at Grafana over a period of time to get a base value for the settings - Not ideal and goldilocks is a much better solution.

My only question / request would be for any RBAC support on the web report? Maybe use auth-headers to limit what namespaces are shown in the report so developers would only see namespaces that they have permission to?

@sudermanjr sudermanjr added the enhancement Adding additional functionality or improvements label Oct 23, 2019
@sudermanjr
Copy link
Member

@robotica72 Thanks for the feedback!

This could be a very interesting and potentially very complicated change. I think it's potentially a good one, but not sure we have the time on our roadmap. We'll definitely consider it for Q1.

We are also open to external additions, if you want to write up a short proposal for how it could be done, we might be able to pull in some external help on this one.

@sudermanjr sudermanjr added the help wanted Extra attention is needed label Oct 23, 2019
@robotica72
Copy link
Author

Hi - Thanks for the quick reply.

If I were to use a common example, I would see it implemented in the same manner that the K8s Dashboard is deployed when using the secured model. We take it a step further by using a reverse-proxy that passes the users JWT token to the Dashboard so they only have access to the objects in the cluster that have been assigned to their groups.

The Dash may not be the best example since that has more functions - I havent looked at the implementation for Goldilocks in depth to see if I can offer any suggestions. If I get a chance over the week/weekend to take a look, Ill reply with some additional information.

Thanks!

@stale
Copy link

stale bot commented Dec 22, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Marked as stale by stalebot label Dec 22, 2019
@stale stale bot closed this as completed Dec 29, 2019
@Fodoj
Copy link

Fodoj commented Jul 5, 2021

Are there any plans to implement this?

@Fodoj
Copy link

Fodoj commented Jul 5, 2021

/no stale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adding additional functionality or improvements help wanted Extra attention is needed stale Marked as stale by stalebot
Projects
None yet
Development

No branches or pull requests

3 participants